Fix regression in custom conversion ordering. #5052
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a regression that prevented user provided custom converters from taking precedence over framework defined ones.
christophstrobl
force-pushed
the
issue/4.5.x/5036
branch
from
2a83087 to
a702fdc
Compare
mp911de
reviewed
Sep 9, 2025
| @@ -378,7 +378,7 @@ ConverterConfiguration createConverterConfiguration() { | |||
|
|
|||
| if (!useNativeDriverJavaTimeCodecs) { | |||
|
|
|||
| converters.addAll(customConverters); | |||
| converters.addAll(0, customConverters); // need to add at index 0!! | |||
There was a problem hiding this comment.
Actually, shouldn't converters go into STORE_CONVERSIONS?
mp911de
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression that prevented user provided custom converters from taking precedence over framework defined ones.
Resolves: #5036