GH-3562: Add AckMode.RECORD_FILTERED #4108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chaedong Im <[email protected]>
Signed-off-by: Chaedong Im <[email protected]>
Signed-off-by: Chaedong Im <[email protected]>
Signed-off-by: Chaedong Im <[email protected]>
Signed-off-by: Chaedong Im <[email protected]>
Signed-off-by: Chaedong Im <[email protected]>
Signed-off-by: Chaedong Im <[email protected]>
Chaedie
force-pushed
the
GH-3562-4
branch
2 times, most recently
from
dc6bc25 to
c0bb203
Compare
Signed-off-by: Chaedong Im <[email protected]>
sobychacko
requested changes
Oct 16, 2025
| * @author Chaedong Im | ||
| * @see AckModeRecordWithFilteringTest | ||
| */ | ||
| public class AckModeRecordFilteredTest { |
There was a problem hiding this comment.
You can drop public modifier from tests.
There was a problem hiding this comment.
I removed it. Thanks 😊
|
|
||
| @SuppressWarnings({"unchecked", "deprecation"}) | ||
| @Test | ||
| public void testRecordFilteredModeOnlyCommitsProcessedRecords() throws InterruptedException { |
There was a problem hiding this comment.
No public modifier needed.
There was a problem hiding this comment.
I removed it. Thanks 😊
|
|
||
| @SuppressWarnings({"unchecked", "deprecation"}) | ||
| @Test | ||
| public void testRecordFilteredModeWithAllRecordsFiltered() throws InterruptedException { |
There was a problem hiding this comment.
no public modifier needed.
There was a problem hiding this comment.
I removed it. Thanks 😊
| * @author Chaedong Im | ||
| * @see AckModeRecordFilteredTest | ||
| */ | ||
| public class AckModeRecordWithFilteringTest { |
There was a problem hiding this comment.
No public modifier needed.
There was a problem hiding this comment.
I removed it. Thanks 😊
sobychacko
reviewed
Oct 16, 2025
| */ | ||
| RECORD, | ||
|
|
||
| /** |
There was a problem hiding this comment.
need to add author tag to the class.
There was a problem hiding this comment.
Oh, I missed this class. I added author tag. Thanks 😊
Signed-off-by: Chaedong Im <[email protected]>
Signed-off-by: Chaedong Im <[email protected]>
…MessageListenerAdapter Signed-off-by: Chaedong Im <[email protected]>
Signed-off-by: Chaedong Im <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3562
Summary
Add a new AckMode
AckMode.RECORD_FILTERED.It will commits offsets only for records that are not filtered by
RecordFilterStrategy.Problem
When RecordFilterStrategy is used with
AckMode.RECORD, the container commits the offset for every record, including those filtered out (never delivered to the listener).This causes unnecessary synchronous commits and can advance offsets for records that were effectively skipped.
Implementation
ContainerProperties.AckMode.RECORD_FILTEREDKafkaMessageListenerContainer: per-record commit path skips filtered recordsFilteringAware+FilteringMessageListenerAdapterto expose filter resultsTests
I wasn’t fully confident about my code, so I hesitated to open this PR for a few weeks. 😅
Please feel free to review it — thank you!