-
Notifications
You must be signed in to change notification settings - Fork 1.7k
GH-3562: Add AckMode.RECORD_FILTERED #4108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Chaedie
wants to merge
12
commits into
spring-projects:main
Choose a base branch
from
Chaedie:GH-3562-4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8640e72
test: add test for AckMode Record and Record Filtered
Chaedie 84aa033
feat: implement AckMode RECORD_FILTERED
Chaedie 27d7eb7
docs: fix year of the Copyright
Chaedie 0458aa1
refactor: move inner class to the end of the class
Chaedie 14cceef
refactor: remove newline
Chaedie c552c92
refactor: add suppress warnings for unchecked exception
Chaedie df86512
refactor: remove unused import
Chaedie 47a728f
refactor: replace deprecated code
Chaedie e32efea
refactor: remove public modifier in the test code
Chaedie 507ddbc
docs: add @author
Chaedie 4e8b8dd
fix: use ThreadLocal to isolate filter result per thread in Filtering…
Chaedie 0beec0c
style: format code
Chaedie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
spring-kafka/src/main/java/org/springframework/kafka/listener/adapter/FilteringAware.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /* | ||
| * Copyright 2025-present the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.kafka.listener.adapter; | ||
|
|
||
| import org.apache.kafka.clients.consumer.ConsumerRecord; | ||
|
|
||
| /** | ||
| * An interface to indicate that a message listener adapter can report | ||
| * whether a record was filtered during processing. | ||
| * | ||
| * @param <K> the key type. | ||
| * @param <V> the value type. | ||
| * | ||
| * @author Chaedong Im | ||
| * @since 4.0 | ||
| */ | ||
| public interface FilteringAware<K, V> { | ||
|
|
||
| /** | ||
| * Check if the most recent record processed was filtered out. | ||
| * This method should be called after a record has been processed | ||
| * to determine if the record was filtered and should not trigger | ||
| * an offset commit in RECORD_FILTERED acknowledge mode. | ||
| * @param record the record to check | ||
| * @return true if the record was filtered, false if it was processed | ||
| */ | ||
| boolean wasFiltered(ConsumerRecord<K, V> record); | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add author tag to the class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I missed this class. I added author tag. Thanks 😊