-
Notifications
You must be signed in to change notification settings - Fork 8
some operators use useMap and prefix #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sweet. I had a similar PR here locally. Wanted to get the concurrent update in, but this is good. We should use prefix for key as well. It's about 2x faster. But there is still quite a bit of key collision (around 1/5) so I'll try and maybe do the % trick and see if that helps. Anyway this needs a benchmark update as well, so lets just get this in first and I'll look at key afterwards. |
Benchmark results
|
Oh, I didn't know you had a branch. Sorry about that.
|
Benchmark results
|
Don't worry about the branch, it was mostly for testing this stuff. Key is 2x faster with useMap |
Interesting! I thought |
Yeah, changing this line from 0 to 1 makes key with useMap go from 10ms to < 1ms. |
But maybe we should add that as an option? prefixOffset? |
I was typing this right now. :) |
Cool, will work on that after lunch. |
Before and after of the perf benchmarks: