-
Notifications
You must be signed in to change notification settings - Fork 706
Make TestPeer use TestChainstate internally #6557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TestPeer use TestChainstate internally #6557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
4baba84
to
6c08f27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Jacinta Ferrant <[email protected]>
6c08f27
to
3612582
Compare
cb09a19
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (58.88%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #6557 +/- ##
===========================================
- Coverage 63.97% 58.88% -5.10%
===========================================
Files 568 568
Lines 347131 347332 +201
===========================================
- Hits 222090 204535 -17555
- Misses 125041 142797 +17756
... and 395 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Make TestPeer use TestChainstate underneath the hood and remove some duplication. I think a lot of tests could be updated to just use TestChainstate (a lot odn't seem to actually need a full TestPeer) but leaving for another PR.