Tracking SyntaxNode and interning through a tracked function

[eytan-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[eytan-starkware]

• Making Stable Syntax Pointers just a wrapper around syntax nodes #8501 : 2 dependent PRs (#8507 , #8513 )
• Tracking SyntaxNode and interning through a tracked function #8489 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[orizi]

@orizi reviewed 2 of 4 files at r1, all commit messages.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

---

crates/cairo-lang-syntax/src/node/mod.rs line 94 at r1 (raw file):

        use salsa::plumbing::AsId;
        self.0.as_id()
    }

is this just for the debug info?

Code quote:

    /// Convert from a tracked ID.
    pub fn from_intern_id(intern_id: salsa::Id) -> Self {
        use salsa::plumbing::FromId;
        Self(SyntaxNodeData::from_id(intern_id))
    }

    /// Convert to a tracked ID.
    pub fn as_intern_id(self) -> salsa::Id {
        use salsa::plumbing::AsId;
        self.0.as_id()
    }

[eytan-starkware]

Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @orizi and @TomerStarkware)

---

crates/cairo-lang-syntax/src/node/mod.rs line 94 at r1 (raw file):

Previously, orizi wrote…

is this just for the debug info?

Yes. it was part of inlining the short_id macro, but I removed these function now.

[orizi]

@orizi reviewed 1 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

---

a discussion (no related file):
but blocking until further oprimizing PRs or release.

[TomerStarkware]

@TomerStarkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eytan-starkware)

[orizi]

@orizi reviewed 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware)

[TomerStarkware]

@TomerStarkware reviewed 1 of 4 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware)