Untracking internal API in syntaxnode creation #8507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
orizi
approved these changes
Oct 8, 2025
There was a problem hiding this comment.
@orizi reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)
eytan-starkware
force-pushed
the
eytan_graphite/making_stable_syntax_pointers_just_a_wrapper_around_syntax_nodes
branch
from
ef2bd29 to
5e44fa2
Compare
eytan-starkware
force-pushed
the
eytan_graphite/untracking_internal_api_in_syntaxnode_creation
branch
from
f278e15 to
57e8234
Compare
eytan-starkware
deleted the
eytan_graphite/untracking_internal_api_in_syntaxnode_creation
branch
This was referenced Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactor SyntaxNode creation to ensure proper tracking and improve performance.
What changed?
new_syntax_nodean internal function that should only be called from tracked contexts