-
Notifications
You must be signed in to change notification settings - Fork 0
adding builtin usage tests #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding builtin usage tests #205
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2d123be to
932e76d
Compare
e577a4e to
e061dd6
Compare
932e76d to
fa20c55
Compare
4b91e6d to
722e685
Compare
2a4f194 to
9f4b9f2
Compare
OmriEshhar1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OmriEshhar1 reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @YairVaknin-starkware)
crates/cairo-program-runner-lib/src/hints/builtin_usage_hints.rs line 284 at r1 (raw file):
#[rstest(finalize, case(true), case(false))] fn test_builtin_usage_add_other_segment(finalize: bool) { // Test the builtin_usage_add_other_segment function with finalize set to true.
it is tested for both finalize=true and finalize=false, isn't it?
Code quote:
with finalize set to true9f4b9f2 to
db67973
Compare
722e685 to
1a731f2
Compare
|
Previously, OmriEshhar1 wrote…
Yes, bad documentation. |
db67973 to
c022280
Compare
OmriEshhar1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OmriEshhar1 reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @YairVaknin-starkware)
9dc011e
into
idanh/enableing_execute_task_tests

Type
Description
Breaking changes?
This change is