-
Notifications
You must be signed in to change notification settings - Fork 0
fixing and adding simple bl hints tests #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1c093d9 to
3498363
Compare
722e685 to
1a731f2
Compare
3498363 to
0a402b5
Compare
1a731f2 to
88a21d2
Compare
0a402b5 to
c2199fe
Compare
c2199fe to
d9cf347
Compare
OmriEshhar1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OmriEshhar1 reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @YairVaknin-starkware)
crates/cairo-program-runner-lib/src/hints/simple_bootloader_hints.rs line 432 at r1 (raw file):
#[fixture] fn fibonacci() -> Program {
this fixture is used in multiple tests.
can't it be put in a common place where it can be used by all tests (without code duplication)?
crates/cairo-program-runner-lib/src/hints/simple_bootloader_hints.rs line 684 at r1 (raw file):
/// This function prepares a VirtualMachine instance for testing simulate_builtin hints. fn prepare_vm_for_simulate_builtin(
maybe put all the auxiliary function at the beginning of the module
d9cf347 to
1c188b9
Compare
590a91a to
2f27437
Compare
1c188b9 to
db0770e
Compare
5c054f6 to
b4788b8
Compare
Idanh-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @OmriEshhar1 and @YairVaknin-starkware)
crates/cairo-program-runner-lib/src/hints/simple_bootloader_hints.rs line 432 at r1 (raw file):
Previously, OmriEshhar1 wrote…
this fixture is used in multiple tests.
can't it be put in a common place where it can be used by all tests (without code duplication)?
Done.
crates/cairo-program-runner-lib/src/hints/simple_bootloader_hints.rs line 684 at r1 (raw file):
Previously, OmriEshhar1 wrote…
maybe put all the auxiliary function at the beginning of the module
Done.
OmriEshhar1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OmriEshhar1 reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @YairVaknin-starkware)

Type
Description
Breaking changes?
This change is