scripts: add an abstraction for the args that depend on each other and validate them in one place

[guyf-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[guyf-starkware]

• scripts: Add an abstraction for how to restart pods. #9798 : 2 dependent PRs (#9799 , #9872 )
• scripts: add an abstraction for the args that depend on each other and validate them in one place #9797 👈 (View in Graphite)
• scripts: fix a bug where the get pod names did not use the namespace and context from args #9809
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[guyf-starkware]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @ShahakShama)

---

scripts/prod/update_config_and_restart_nodes_lib.py line 600 at r1 (raw file):

    for index, config in enumerate(configs):
        print(f"Applying config {index}...")
        # apply_configmap(

This is left commented out while in review to make sure we don't accidentally do something. Adding this blocking comment to avoid accidental merge with this still commented out

---

scripts/prod/update_config_and_restart_nodes_lib.py line 609 at r1 (raw file):

    if restart_strategy != RestartStrategy.NO_RESTART:
        for index, config in enumerate(configs):
            # restart_pod(

This is left commented out while in review to make sure we don't accidentally do something. Adding this blocking comment to avoid accidental merge with this still commented out

[ShahakShama]

@ShahakShama reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @guyf-starkware)

---

scripts/prod/update_config_and_restart_nodes_lib.py line 600 at r1 (raw file):

Previously, guyf-starkware wrote…

This is left commented out while in review to make sure we don't accidentally do something. Adding this blocking comment to avoid accidental merge with this still commented out

Just making sure, you mean you'll uncomment this before merging (and not delete this), right?

---

scripts/prod/update_config_and_restart_nodes_lib.py line 609 at r1 (raw file):

Previously, guyf-starkware wrote…

This is left commented out while in review to make sure we don't accidentally do something. Adding this blocking comment to avoid accidental merge with this still commented out

Just making sure, you mean you'll uncomment this before merging (and not delete this), right?Just making sure, you mean you'll uncomment this before merging (and not delete this), right?

---

scripts/prod/update_config_and_restart_nodes_lib.py line 512 at r2 (raw file):

    def get_cluster(self, index: int) -> Optional[str]:
        return self.cluster_list[index] if self.cluster_list else None

Our python conventions is to write explicitly if x is not None and not if x

[guyf-starkware]

Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @ShahakShama)

---

scripts/prod/update_config_and_restart_nodes_lib.py line 600 at r1 (raw file):

Previously, ShahakShama wrote…

Just making sure, you mean you'll uncomment this before merging (and not delete this), right?

Yes. I made this blocking comment to make sure I don't mege by mistake before resolving the comment (and uncomment the code)

---

scripts/prod/update_config_and_restart_nodes_lib.py line 609 at r1 (raw file):

Previously, ShahakShama wrote…

Just making sure, you mean you'll uncomment this before merging (and not delete this), right?Just making sure, you mean you'll uncomment this before merging (and not delete this), right?

Same as above

---

scripts/prod/update_config_and_restart_nodes_lib.py line 512 at r2 (raw file):

Previously, ShahakShama wrote…

Our python conventions is to write explicitly if x is not None and not if x

Done

[guyf-starkware]

@guyf-starkware reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @guyf-starkware)

[guyf-starkware]

@guyf-starkware reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @guyf-starkware)