scripts: Remove (wrong) to_lower for service argument #9824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Oct 28, 2025
guyf-starkware
changed the base branch from
10-27-scripts_add_an_abstraction_for_how_to_restart_pods
to
graphite-base/9824
guyf-starkware
force-pushed
the
graphite-base/9824
branch
from
29b6bee to
9f79647
Compare
guyf-starkware
force-pushed
the
10-28-scripts_remove_wrong_to_lower_for_service_argument
branch
from
2ee52ec to
5a9efa9
Compare
guyf-starkware
changed the base branch from
graphite-base/9824
to
main-v0.14.1
ShahakShama
approved these changes
Oct 30, 2025
Collaborator
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guyf-starkware)
guyf-starkware
force-pushed
the
10-28-scripts_remove_wrong_to_lower_for_service_argument
branch
from
5a9efa9 to
45e345b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.