-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_dashboard: simpler new fn for Panel #9856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_dashboard: simpler new fn for Panel #9856
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
78a13b3 to
0f23e90
Compare
b710d56 to
56dd569
Compare
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion
crates/apollo_dashboard/src/dashboard_test.rs line 132 at r2 (raw file):
#[should_panic] fn thresholds_first_step_must_be_none() { let _ = Panel::new("x", "x", "y".into(), PanelType::Stat).with_absolute_thresholds(vec
No description provided.