Skip to content

Conversation

@matanl-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

matanl-starkware commented Oct 29, 2025

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion


crates/apollo_dashboard/src/dashboard_test.rs line 132 at r2 (raw file):

#[should_panic]
fn thresholds_first_step_must_be_none() {
    let _ = Panel::new("x", "x", "y".into(), PanelType::Stat).with_absolute_thresholds(vec![

You can remove this afaiu

Code quote:

.into()

@matanl-starkware matanl-starkware force-pushed the 10-29-apollo_dashboard_simpler_new_fn_for_panel branch from 56dd569 to aee5cdc Compare October 30, 2025 15:48
@matanl-starkware matanl-starkware force-pushed the 10-29-apollo_dashboard_simpler_new_fn_for_panel branch from aee5cdc to f55bde5 Compare October 30, 2025 17:49
Copy link
Collaborator Author

@matanl-starkware matanl-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


crates/apollo_dashboard/src/dashboard_test.rs line 132 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

You can remove this afaiu

Done.

@matanl-starkware matanl-starkware marked this pull request as ready for review October 30, 2025 17:57
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Itay-Tsabary-Starkware reviewed 10 of 14 files at r1, 2 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matanl-starkware)

@matanl-starkware matanl-starkware added this pull request to the merge queue Nov 2, 2025
Merged via the queue into main-v0.14.1 with commit 48a2feb Nov 2, 2025
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants