apollo_dashboard: create MetricCommon trait

[matanl-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[matanl-starkware]

• apollo_dashboard: use query_builder increase fn in panels #9866
• apollo_dashboard: add new module queries_builder #9863
• apollo_dashboard: create MetricCommon trait #9857 👈 (View in Graphite)
• apollo_dashboard: simpler new fn for Panel #9856
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-10-30T10:56:51Z
• Started at 2025-10-30T11:07:05Z
• Started at 2025-10-30T11:07:06Z
• Started at 2025-10-30T13:14:26Z
• Started at 2025-10-30T13:34:47Z
• Started at 2025-10-30T15:48:36Z
• Started at 2025-10-30T17:49:09Z
• Started at 2025-10-30T18:03:23Z
• Started at 2025-11-02T11:03:32Z

[github-actions]

Benchmark movements: tree_computation_flow performance improved 😺 tree_computation_flow time: [13.782 ms 13.939 ms 14.096 ms] change: [-4.9950% -3.5745% -2.0722%] (p = 0.00 < 0.05) Performance has improved. Found 1 outliers among 100 measurements (1.00%) 1 (1.00%) high mild full_committer_flow performance regressed! full_committer_flow time: [15.202 ms 15.323 ms 15.448 ms] change: [+2.0848% +3.3243% +4.5808%] (p = 0.00 < 0.05) Performance has regressed. Found 5 outliers among 100 measurements (5.00%) 5 (5.00%) high mild

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 31 files reviewed, 1 unresolved discussion

---

crates/apollo_metrics/src/metrics.rs line 54 at r1 (raw file):

#[derive(Clone, Debug)]
struct Metric {

Can also impl MetricCommon

Code quote:

struct Metric

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 31 files reviewed, 2 unresolved discussions (waiting on @matanl-starkware)

---

crates/apollo_metrics/src/metrics.rs line 79 at r1 (raw file):

        initial_value: u64,
    ) -> Self {
        Self { metric: Metric { scope, name, description }, initial_value }

wdyt about a new fn?

Code quote:

 Metric { scope, name, description }

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 31 files reviewed, 3 unresolved discussions (waiting on @matanl-starkware)

---

crates/apollo_metrics/src/metrics.rs line 54 at r1 (raw file):

#[derive(Clone, Debug)]
struct Metric {

wdyt about:
Metric (struct) -> MetricProperties / MetricCommonProperties / MetricAttributes / MetricCommonAttributes
MetricCommon (trait) -> Metric{whatever-comes-here-according-to-the-previous}Reader

Code quote:

 Metric

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 31 files reviewed, 4 unresolved discussions (waiting on @matanl-starkware)

---

crates/apollo_metrics/src/metrics.rs line 192 at r1 (raw file):

    fn get_description(&self) -> &'static str {
        self.metric.description
    }

Please implement once for the inner common member, and for the outer one call the fn on the inner

Code quote:

    fn get_name(&self) -> &'static str {
        self.metric.name
    }

    fn get_name_with_filter(&self) -> String {
        format!("{}{}", self.metric.name, metric_label_filter!())
    }

    fn get_scope(&self) -> MetricScope {
        self.metric.scope
    }

    fn get_description(&self) -> &'static str {
        self.metric.description
    }

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 31 files reviewed, 4 unresolved discussions (waiting on @matanl-starkware)

---

crates/apollo_metrics/src/metrics.rs line 192 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please implement once for the inner common member, and for the outer one call the fn on the inner

Also since this is just boilerplating of calling the inner fn I'd consider a macro:

1. the most elegant solution seems like a proc macro, which happens to be already implemented in this https://crates.io/crates/ambassador
2. if we prefer to avoid adding a dependency we can impl it ourselfs (not fun but doable)
3. we can also go for a simpler macro like:

/// Expands to:
/// fn NAME(&self) -> T { self.inner.NAME() }
///
/// Usage (inside an `impl` block):
/// delegate_inner_fn!(ping -> u32);
macro_rules! delegate_inner_fn {
    ($name:ident -> $ret:ty) => {
        fn $name(&self) -> $ret {
            self.inner.$name()
        }
    };
}

and the invocations will be

impl Metric for MetricGauge {
    delegate_inner_fn!(get_name -> &'static str);
    ...
}

I suggest option 1

[matanl-starkware]

Reviewable status: 0 of 31 files reviewed, 4 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/apollo_metrics/src/metrics.rs line 54 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Can also impl MetricCommon

Done.

---

crates/apollo_metrics/src/metrics.rs line 54 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

wdyt about:
Metric (struct) -> MetricProperties / MetricCommonProperties / MetricAttributes / MetricCommonAttributes
MetricCommon (trait) -> Metric{whatever-comes-here-according-to-the-previous}Reader

Overkill IMO. It can be done someday if necessary.

---

crates/apollo_metrics/src/metrics.rs line 79 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

wdyt about a new fn?

Done.

---

crates/apollo_metrics/src/metrics.rs line 192 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Also since this is just boilerplating of calling the inner fn I'd consider a macro:

1. the most elegant solution seems like a proc macro, which happens to be already implemented in this https://crates.io/crates/ambassador
2. if we prefer to avoid adding a dependency we can impl it ourselfs (not fun but doable)
3. we can also go for a simpler macro like:

/// Expands to:
/// fn NAME(&self) -> T { self.inner.NAME() }
///
/// Usage (inside an `impl` block):
/// delegate_inner_fn!(ping -> u32);
macro_rules! delegate_inner_fn {
    ($name:ident -> $ret:ty) => {
        fn $name(&self) -> $ret {
            self.inner.$name()
        }
    };
}

and the invocations will be

impl Metric for MetricGauge {
    delegate_inner_fn!(get_name -> &'static str);
    ...
}

I suggest option 1

Done.

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware reviewed 26 of 31 files at r1, 1 of 1 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matanl-starkware)

[graphite-app]

Merge activity

• Nov 2, 11:04 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

[matanl-starkware]

@matanl-starkware reviewed 24 of 31 files at r1, 1 of 1 files at r2, 4 of 4 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matanl-starkware)