chore: add existing checks to pre-commit, use pre-commit in CI

[arad-starkware]

This change is 

---

Note

Run pre-commit in CI, add hooks for flow tests and Cairo formatting, and remove redundant Python/setup and formatting steps from the workflow.

• CI (GitHub Actions):
  • Add pre-commit job running with setup-snfoundry, setup-scarb, and pre-commit/action (with SKIP=scarb-toml-url-lock).
  • Remove Python setup and direct flow-test check; drop scarb fmt --check from test job.
• Pre-commit Hooks:
  • Add ensure-flow-struct-tests (runs scripts/check_all_flows_have_test.py --allow-duplicate-tests).
  • Add cairo-scarb-fmt (scarb fmt -w --check).
  • Keep scarb-toml-url-lock; configure stages (pre-commit, pre-push, manual).
• Scripts:
  • Make scripts/check_all_flows_have_test.py executable via shebang.

^{Written by Cursor Bugbot for commit 4a2bac2. This will update automatically on new commits. Configure here.}

[arad-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore: add existing checks to pre-commit, use pre-commit in CI #52 👈 (View in Graphite)
• chore: update pre-commit stage name #54
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.60%. Comparing base (a28d60e) to head (8bbad41).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   95.43%   95.60%   +0.16%     
==========================================
  Files          45       45              
  Lines        9446     9783     +337     
==========================================
+ Hits         9015     9353     +338     
+ Misses        431      430       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[noa-starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @NirLevi-starkware)

---

.pre-commit-config.yaml line 6 at r2 (raw file):

      - id: cairo-scarb-fmt
        name: check cairo code is formatted
        entry: scarb fmt -w --check

Is this going to slow the push?

[arad-starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @NirLevi-starkware and @noa-starkware)

---

.pre-commit-config.yaml line 6 at r2 (raw file):

Previously, noa-starkware wrote…

Is this going to slow the push?

Not the push, but the commit: yea, a bit.

[noa-starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @arad-starkware and @NirLevi-starkware)

---

.pre-commit-config.yaml line 6 at r2 (raw file):

Previously, arad-starkware wrote…

Not the push, but the commit: yea, a bit.

Lets try it for now and maybe remove it later

[noa-starkware]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @arad-starkware and @NirLevi-starkware)

---

.pre-commit-config.yaml line 12 at r2 (raw file):

      - id: ensure-flow-struct-tests
        name: ensure flow structs have tests
        entry: scripts/check_all_flows_have_test.py --allow-duplicate-tests

Is this necessary here?

[arad-starkware]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @NirLevi-starkware and @noa-starkware)

---

.pre-commit-config.yaml line 12 at r2 (raw file):

Previously, noa-starkware wrote…

Is this necessary here?

I wouldn't say any of these checks (in this PR) are necessary, since they're checked in the CI. But I think it's better to find this out here instead of only after pushing.

[cursor]

Bug: Python setup removed but hooks need Python

The pre-commit job removed the explicit Python setup that was in the old verify_flows job, but the pre-commit hooks still run Python scripts (check_all_flows_have_test.py and check_scarb_url_lock.py configured with language: system). While ubuntu-latest has Python pre-installed, relying on it without explicit setup is fragile and could break if GitHub modifies their runner images.

 

[cursor]

Bug: Pre-push hooks won't run in CI

The cairo-scarb-fmt and ensure-flow-struct-tests hooks are configured with stages: [pre-push], but the CI job uses pre-commit/action which runs pre-commit run --all-files by default. This command only executes hooks in the commit stage, so these two important checks that previously ran in CI will no longer execute. The workflow needs to specify --hook-stage push or --hook-stage manual, or the hooks should use stages: [commit] or stages: [manual] to run in CI.

Additional Locations (1)

• .pre-commit-config.yaml#L10-L16