Skip to content

Conversation

@arad-starkware
Copy link
Collaborator

@arad-starkware arad-starkware commented Nov 23, 2025

This change is Reviewable


Note

Adds a local pre-commit hook that blocks changes to the url line in Scarb.toml by inspecting the staged diff.

  • Tooling / Pre-commit:
    • Add local hook scarb-toml-url-lock in .pre-commit-config.yaml targeting Scarb.toml at commit stage.
    • Introduce scripts/check_scarb_url_lock.py to inspect the staged diff of Scarb.toml and fail if +url or -url changes are detected.

Written by Cursor Bugbot for commit c44bef8. This will update automatically on new commits. Configure here.

Copy link
Collaborator Author

arad-starkware commented Nov 23, 2025

@arad-starkware arad-starkware force-pushed the arad/chore_add_check_for_rpc_url branch from 75d690e to 4939c4b Compare November 23, 2025 12:57
@arad-starkware arad-starkware force-pushed the arad/chore_add_pre-commit branch from bc32940 to 04e5d6b Compare November 23, 2025 12:57
Copy link
Collaborator

@noa-starkware noa-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @arad-starkware and @NirLevi-starkware)

Copy link
Collaborator Author

@arad-starkware arad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @NirLevi-starkware and @noa-starkware)

Copy link
Collaborator

@noa-starkware noa-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @arad-starkware and @NirLevi-starkware)

Copy link
Collaborator

@noa-starkware noa-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @arad-starkware and @NirLevi-starkware)

@arad-starkware arad-starkware force-pushed the arad/chore_add_check_for_rpc_url branch from 4939c4b to af890b8 Compare November 23, 2025 15:01
@arad-starkware arad-starkware force-pushed the arad/chore_add_pre-commit branch 2 times, most recently from 80f98bd to 9c47c2d Compare November 23, 2025 15:23
@arad-starkware arad-starkware force-pushed the arad/chore_add_check_for_rpc_url branch from af890b8 to f1a3f80 Compare November 23, 2025 15:23
@arad-starkware arad-starkware force-pushed the arad/chore_add_pre-commit branch from 9c47c2d to 5a66e7e Compare November 23, 2025 15:29
@arad-starkware arad-starkware force-pushed the arad/chore_add_check_for_rpc_url branch from f1a3f80 to 149e559 Compare November 23, 2025 15:29
@arad-starkware arad-starkware changed the base branch from arad/chore_add_pre-commit to graphite-base/53 November 23, 2025 16:29
@arad-starkware arad-starkware force-pushed the arad/chore_add_check_for_rpc_url branch from 149e559 to 689096d Compare November 23, 2025 16:29
@arad-starkware arad-starkware changed the base branch from graphite-base/53 to main November 23, 2025 16:29
@arad-starkware arad-starkware force-pushed the arad/chore_add_check_for_rpc_url branch from 689096d to 894eed0 Compare November 23, 2025 16:37
@arad-starkware arad-starkware force-pushed the arad/chore_add_check_for_rpc_url branch from 894eed0 to c44bef8 Compare November 23, 2025 16:38
@codecov
Copy link

codecov bot commented Nov 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.60%. Comparing base (a28d60e) to head (c44bef8).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   95.43%   95.60%   +0.16%     
==========================================
  Files          45       45              
  Lines        9446     9783     +337     
==========================================
+ Hits         9015     9353     +338     
+ Misses        431      430       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arad-starkware arad-starkware merged commit 411f3b9 into main Nov 23, 2025
6 of 7 checks passed
Copy link
Collaborator Author

Merge activity

@arad-starkware arad-starkware deleted the arad/chore_add_check_for_rpc_url branch November 23, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants