Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use setJointAnglesOfGroup() and playPattern(), use clearJointAngles() with test #1071

Merged
merged 13 commits into from
Dec 18, 2019
Merged

use setJointAnglesOfGroup() and playPattern(), use clearJointAngles() with test #1071

merged 13 commits into from
Dec 18, 2019

Conversation

pazeshun
Copy link
Collaborator

@pazeshun pazeshun commented Oct 25, 2019 •
edited
Loading

This PR includes #1070, #765, and k-okada#10

@pazeshun pazeshun changed the title use setJointAnglesOfGroup() and playPattern(), use clearJointAngles() use setJointAnglesOfGroup() and playPattern(), use clearJointAngles() with test Oct 25, 2019
@pazeshun pazeshun changed the title use setJointAnglesOfGroup() and playPattern(), use clearJointAngles() with test [WIP] use setJointAnglesOfGroup() and playPattern(), use clearJointAngles() with test Oct 25, 2019
@pazeshun pazeshun force-pushed the add-cancel-smooth-with-test branch from 1ba96a6 to f8bd4ec Compare October 25, 2019 16:51
@pazeshun pazeshun mentioned this pull request Oct 25, 2019
Closed
@pazeshun
Copy link
Collaborator Author

Please see #1070 (comment) and k-okada#10 (comment) for some details.

@pazeshun pazeshun mentioned this pull request Oct 26, 2019
Merged
@pazeshun
Copy link
Collaborator Author

pazeshun commented Oct 26, 2019 •
edited
Loading

Not tested with real robots Tested with HRP2 and HIRONX.

This was referenced Oct 30, 2019
Closed
Closed
@pazeshun pazeshun changed the title [WIP] use setJointAnglesOfGroup() and playPattern(), use clearJointAngles() with test use setJointAnglesOfGroup() and playPattern(), use clearJointAngles() with test Nov 18, 2019
@pazeshun
Copy link
Collaborator Author

Now being tested on HRP2 with #1075 and on HIRONX with #1079

@pazeshun pazeshun changed the title use setJointAnglesOfGroup() and playPattern(), use clearJointAngles() with test [WIP] use setJointAnglesOfGroup() and playPattern(), use clearJointAngles() with test Nov 18, 2019
@pazeshun pazeshun force-pushed the add-cancel-smooth-with-test branch 2 times, most recently from e0810e1 to bf3607f Compare November 19, 2019 00:34
@pazeshun pazeshun mentioned this pull request Nov 30, 2019
Open
@pazeshun pazeshun force-pushed the add-cancel-smooth-with-test branch 2 times, most recently from 679e992 to 5c2b619 Compare November 30, 2019 15:11
@pazeshun
Copy link
Collaborator Author

pazeshun commented Dec 5, 2019

NOTE: Currently, some features of this PR don't work, because hrpsys 315.16.0 doesn't exist:
https://github.com/start-jsk/rtmros_common/pull/1071/files#diff-58737e307d5564178dd2ba38f8f46d72R503-R504
https://github.com/start-jsk/rtmros_common/pull/1071/files#diff-58737e307d5564178dd2ba38f8f46d72R556-R557
https://github.com/start-jsk/rtmros_common/pull/1071/files#diff-58737e307d5564178dd2ba38f8f46d72R591-R592

@pazeshun pazeshun changed the title [WIP] use setJointAnglesOfGroup() and playPattern(), use clearJointAngles() with test use setJointAnglesOfGroup() and playPattern(), use clearJointAngles() with test Dec 5, 2019
@pazeshun pazeshun added this to the 1.4.3 milestone Dec 5, 2019
@pazeshun pazeshun force-pushed the add-cancel-smooth-with-test branch from 6c09f5d to 35377e7 Compare December 17, 2019 04:55
@pazeshun
Copy link
Collaborator Author

@k-okada
I resolved conflicts in #1070 and rebased this PR on #1070.
Travis correctly failed in #1070 and succeeded in this PR.
Could you review this PR again?

@pazeshun pazeshun requested a review from k-okada December 17, 2019 14:33
@k-okada k-okada merged commit 99b26e5 into start-jsk:master Dec 18, 2019
@pazeshun
Copy link
Collaborator Author

Thank you!!!

@pazeshun pazeshun deleted the add-cancel-smooth-with-test branch December 18, 2019 05:51
@pazeshun pazeshun mentioned this pull request Dec 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-okada k-okada Awaiting requested review from k-okada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@pazeshun @k-okada