Skip to content

[McpBundle] Wire & configure services explicitly #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

valtzu
Copy link
Contributor

@valtzu valtzu commented Jul 19, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues Related to #90
License MIT

Don't autowire / autoconfigure any services in mcp bundle

@chr-hertel chr-hertel added the MCP Bundle Issues & PRs about the MCP SDK integration bundle label Jul 19, 2025
@valtzu valtzu force-pushed the wire-explicitly-mcp branch from 883efeb to 52a1803 Compare July 20, 2025 17:30
@valtzu
Copy link
Contributor Author

valtzu commented Jul 20, 2025

Covers McpBundle part of #77 too

@valtzu valtzu force-pushed the wire-explicitly-mcp branch from 52a1803 to f0a63bd Compare July 20, 2025 18:07
@@ -19,10 +19,10 @@ services:
- '../src/Entity/'
- '../src/Kernel.php'

Symfony\AI\McpSdk\Capability\Tool\ToolExecutorInterface:
mcp.tool_executor:
Copy link
Contributor Author

@valtzu valtzu Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite sure about this.

I'm not familiar with this MCP bundle at all – is this really how this is supposed to work? Don't we have some autoconfiguration, or explicit config within the app is always needed? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #168 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MCP Bundle Issues & PRs about the MCP SDK integration bundle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants