Updates for feat/ldk-node-serializable#32
Conversation
| let address = ''; | ||
| if (which === 'bitcoin') { | ||
| address = uri.replace(/^bitcoin:/, '').replace(/\?.*$/, ''); | ||
| if (!address.startsWith('bcrt')) { |
There was a problem hiding this comment.
Beware of this check... It is only valid for REGTEST.
Please research "the valid bitcoin addresses prefix for each network" and best to adjust this so it accepts for the valid prefix for each bitcoin network.
There was a problem hiding this comment.
Fair enough, although I believe that the tests will be executed only against regtest.
| if (!ln) { | ||
| throw new Error(`No lightning invoice found in uri: ${uri}`); | ||
| } | ||
| if (!ln.startsWith('lnbcrt')) { |
There was a problem hiding this comment.
Same here, 'lnbcrt' is the valid bolt11 prefix for REGTEST, for other networks is different.
|
Please add me as reviewer from now on, wherever it can help. I want to have a better understanding of these tests for when they fail so I can predict what might be wrong, instead of always asking you to investigate. |
piotr-iohk
force-pushed
the
feat/ldk-node-serializable
branch
from
ded38bb to
d225c1c
Compare
| Absolutely — that’s a super clean way to present it 👌 | ||
| A two-column **Android | iOS** table makes your setup instantly clear for contributors. | ||
| Here’s a polished Markdown version that fits your style: |
There was a problem hiding this comment.
"You're Absolutely Right!"™ 🚀
There was a problem hiding this comment.
that belongs to different PR, and also 🤦
|
I think this can be already merged 👍🏻 |
piotr-iohk
force-pushed
the
feat/ldk-node-serializable
branch
from
5103916 to
d225c1c
Compare
2 participants
Updates for synonymdev/bitkit-android#434