Skip to content

Updates for feat/ldk-node-serializable #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piotr-iohk merged 2 commits into from
Oct 14, 2025
Merged

Updates for feat/ldk-node-serializable #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e808f8c
Add checks when getting btc or lightning reveive address
piotr-iohk Oct 14, 2025
d225c1c
extend the check for networks beyond regtest
piotr-iohk Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions test/helpers/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,13 +483,29 @@ export async function getAddressFromQRCode(which: addressType): Promise<string>
let address = '';
if (which === 'bitcoin') {
address = uri.replace(/^bitcoin:/, '').replace(/\?.*$/, '');
// Accept Bech32 HRPs across networks: mainnet (bc1), testnet/signet (tb1), regtest (bcrt1)
const allowedBitcoinHrp = ['bc1', 'tb1', 'bcrt1'];
const addrLower = address.toLowerCase();
if (!allowedBitcoinHrp.some((p) => addrLower.startsWith(p))) {
throw new Error(
`Invalid Bitcoin address HRP: ${address}. Expected one of: ${allowedBitcoinHrp.join(', ')}`
);
}
} else if (which === 'lightning') {
const query = uri.split('?')[1] ?? '';
const params = new URLSearchParams(query);
const ln = params.get('lightning');
if (!ln) {
throw new Error(`No lightning invoice found in uri: ${uri}`);
}
// Accept BOLT11 HRPs across networks: mainnet (lnbc), testnet (lntb), signet (lntbs), regtest (lnbcrt)
const allowedLightningHrp = ['lnbc', 'lntb', 'lntbs', 'lnbcrt'];
const lnLower = ln.toLowerCase();
if (!allowedLightningHrp.some((p) => lnLower.startsWith(p))) {
throw new Error(
`Invalid lightning invoice HRP: ${ln}. Expected one of: ${allowedLightningHrp.join(', ')}`
);
}
address = ln;
} else {
throw new Error(`Unknown address type: ${which}`);
Expand Down