fix(vue): skip deleting portal root node to avoid race condition #3745
+1
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even w/ the latest version of HeaadlessUI for Vue I was running into an issue where if a new dialog starts opening up while a previous dialog is in the process of closing down you can run into an issue where the old dialog starts removing the shared PortalRoot while the new dialog has already chosen to rely on it as its PortalRoot. This then ends up breaking the rendering of the 2nd dialog as it ends up being unmounted from the DOM along with the PortalRoot.
The fix is easy - just skip removing the portal root. I don't see any real benefits for removing it, I mean its just one single empty div node, there's no performance gain to having it be removed, and keeping it around fixes the race condition issue.