Merged
Conversation
Changes `Database::read` to return the bytes written not including the offset.
9 tasks
|
Benchmark results for revision cf5bc6e:
Full results
Compare the results above with those for the default branch. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
- Coverage 91.07% 91.07% -0.01%
==========================================
Files 110 110
Lines 20831 20831
Branches 20831 20831
==========================================
- Hits 18972 18971 -1
- Misses 1486 1487 +1
Partials 373 373 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thomasathorne
approved these changes
Feb 10, 2026
vapourismo
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocks RV-859
What
Fixes and adds a test for a bug introduced by #701. Found in #781
Why
The value returned was the index of the final byte, erroneously including the offset. It now only returns the length of what was copied.
Manually Testing
Tasks for the Author