Skip to content

fix(Database): return bytes written #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kurtisc merged 1 commit into from
Feb 10, 2026
Merged

fix(Database): return bytes written #804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions durable-storage/src/database.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ impl Database {

let source_slice = &value_ref[offset..end];
output.put_slice(source_slice);
Ok(end)
Ok(source_slice.len())
}

/// Inserts the value associated with the provided key, replacing any data already associated
Expand Down Expand Up @@ -475,32 +475,36 @@ mod tests {
prop_assert_eq!(&read_data[data.len()..], &read_data_before[data.len()..]);
let read_data_before = read_data;

database
let read = database
.read(&key, data.len(), read_data.as_mut_slice())
.expect("A zero-sized write should succeed");
prop_assert_eq!(read, 0);
prop_assert_eq!(read_data, read_data_before);

// Whole value write
database
let read = database
.read(&key, 0, read_data.as_mut_slice())
.expect("Writing the whole value should succeed");
prop_assert_eq!(read, data.len());
prop_assert_eq!(&read_data[..data.len()], data.as_slice());
prop_assert_eq!(&read_data[data.len()..], &read_data_before[data.len()..]);

// Partial value write
prop_assert_eq!(&read_data[2..data.len()], &data[2..]);
database
let read = database
.read(&key, data.len() - 1, read_data[1..2].as_mut())
.expect("A partial write should succeed");
prop_assert_eq!(read, 1);
prop_assert_eq!(&read_data[1..2], &data[data.len() - 1..]);
prop_assert_eq!(&read_data[2..data.len()], &data[2..]);
prop_assert_eq!(&read_data[data.len()..], &read_data_before[data.len()..]);

// Write limited by buffer
let mut small_buffer: [u8; 3] = [0, 0 ,0];
database
let read = database
.read(&key, 0, small_buffer.as_mut_slice())
.expect("Writing into a smaller buffer should succeed");
prop_assert_eq!(read, small_buffer.len());
prop_assert_eq!(&small_buffer, &data[0..3]);
}
}
Expand Down
Loading