Skip to content

AVL benchmark fix#805

Merged
kurtisc merged 1 commit intomainfrom
kurtis/durable-storage/avl-resolver-fix
Feb 10, 2026
Merged

AVL benchmark fix#805
kurtisc merged 1 commit intomainfrom
kurtis/durable-storage/avl-resolver-fix

Conversation

@kurtisc
Copy link
Contributor

@kurtisc kurtisc commented Feb 10, 2026

Blocks #788 , which aims for a more comprehensive solution

What

Fixes the AVL benchmark, which is currently broken.

Why

The benchmark isn't built unless the "bench" feature is passed, so the compilation issues aren't caught in CI

How

  • Exposes the used methods/types
  • Uses ArcResolver in the benchmark code

Manually Testing

cargo bench --features="bench"

Tasks for the Author

  • Link all Linear issues related to this MR using magic words (e.g. part of, relates to, closes).
  • Eliminate dead code and other spurious artefacts introduced in your changes.
  • Document new public functions, methods and types.
  • Make sure the documentation for updated functions, methods, and types is correct.
  • Add tests for bugs that have been fixed.
  • Explain changes to regression test captures when applicable.
  • Write commit messages in agreement with our guidelines.
  • Self-review your changes to ensure they are high-quality.
  • Complete all of the above before assigning this MR to reviewers.

Exposes `ArcResolver`, `Node` and `Tree::set` when the "bench" feature
is enabled.

Updates the `avl_tree` benchmark to pass the resolver to `Tree` methods.
@github-actions
Copy link

Benchmark results for revision 6a4dfff:

Metric Duration TPS
Mean 1.520982233s 26.299
Worst 1.53170475s 26.115
Best 1.512108321s 26.453
Standard Deviation ±5.054666ms ±0.087
Full results
Run Transfers Duration TPS
1 40 1.53170475s 26.115
2 40 1.52272069s 26.269
3 40 1.519964788s 26.316
4 40 1.51974901s 26.320
5 40 1.51622565s 26.381
6 40 1.520210549s 26.312
7 40 1.519742318s 26.320
8 40 1.52906672s 26.160
9 40 1.522691088s 26.269
10 40 1.518718274s 26.338
11 40 1.516457861s 26.377
12 40 1.521528315s 26.289
13 40 1.528523276s 26.169
14 40 1.513476234s 26.429
15 40 1.521599826s 26.288
16 40 1.512108321s 26.453
17 40 1.526849856s 26.198
18 40 1.523464865s 26.256
19 40 1.519992248s 26.316
20 40 1.514850028s 26.405

Compare the results above with those for the default branch.

@kurtisc kurtisc enabled auto-merge February 10, 2026 10:17
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.07%. Comparing base (68bfca7) to head (e0654b0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #805   +/-   ##
=======================================
  Coverage   91.06%   91.07%           
=======================================
  Files         110      110           
  Lines       20831    20831           
  Branches    20831    20831           
=======================================
+ Hits        18970    18971    +1     
+ Misses       1488     1487    -1     
  Partials      373      373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kurtisc kurtisc added this pull request to the merge queue Feb 10, 2026
Merged via the queue into main with commit 97efced Feb 10, 2026
8 checks passed
@kurtisc kurtisc deleted the kurtis/durable-storage/avl-resolver-fix branch February 10, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants