This repository was archived by the owner on Dec 4, 2025. It is now read-only.
Fixed setup_path() asking for confirmation twice#19
Closed
neijrr wants to merge 9 commits into
Closed
Conversation
github, why you cant just copy from original and put into fork
Contributor
|
Will get around to this eventually, but I'd like to merge #11 first since it's heavily modifying the same file, and that seems like a headache to disentangle. |
Contributor
Author
|
I updated it to be able to merge with new version |
Contributor
Author
|
fix broke, irony |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of how setup_path() works, there is unintentional (I guess) side effect of asking confirmation twice for custom install path (saying no to install in sourcemod folder and saying no to install in current directory)