Skip to content

Conversation

@iTrooz
Copy link
Contributor

@iTrooz iTrooz commented Oct 28, 2025

Checklist

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR contains at most 5 new pages. (5 real news, 4 redirects ?)
  • The PR is authored by me, or has been human-reviewed if it was created with AI or machine translation software.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new translation PRs translating a page(s) from English to other languages. label Oct 28, 2025
@iTrooz
Copy link
Contributor Author

iTrooz commented Oct 28, 2025

Btw, should we say (style guide)

View documentation for `adb disconnect`

or (alias pages)

View documentation for the original command

?

@iTrooz
Copy link
Contributor Author

iTrooz commented Oct 28, 2025

Uhhhhh
Both files seem to have 4 commands ?

@Managor
Copy link
Member

Managor commented Oct 29, 2025

https://github.com/tldr-pages/tldr/blob/main/pages/common/adb-forward.md
5

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR at commit
d1787c338f31c2717a0b7041e94b01605f65c2f4:

  • The page pages.fr/common/adb-forward.md is outdated, based on number of commands, compared to the English page.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@Managor
Copy link
Member

Managor commented Oct 30, 2025

Btw, should we say (style guide)

View documentation for `adb disconnect`

or (alias pages)

View documentation for the original command

?

It's not an alias page.

@iTrooz
Copy link
Contributor Author

iTrooz commented Oct 30, 2025

Btw, should we say (style guide)

View documentation for `adb disconnect`

or (alias pages)

View documentation for the original command

?

It's not an alias page.

I've made the changes. But does it really add something to have different wordings in these similar cases ?

@Managor
Copy link
Member

Managor commented Oct 30, 2025

Yes. This is a move notice of the command being grouped with another command. An alias would be if the two commands were equal.

Copy link
Member

@Managor Managor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conversations once they are resolved.

@iTrooz iTrooz requested a review from noraj October 31, 2025 07:27
@Managor Managor added the hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. label Oct 31, 2025
@Managor
Copy link
Member

Managor commented Nov 4, 2025

@noraj

@noraj
Copy link
Contributor

noraj commented Nov 4, 2025

#19128 have been accepted, so that's why I unresolved https://github.com/tldr-pages/tldr/pull/19096/files/8809dd7cadcfd1f70050a9806e5d0589c6589a4b and I'm still waiting for voir to be changed into affiche.

Signed-off-by: iTrooz <[email protected]>
Copy link
Contributor

@noraj noraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@Managor Managor merged commit 19a39cb into tldr-pages:main Nov 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. new translation PRs translating a page(s) from English to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants