-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
adb-*: add French translation #19096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Btw, should we say (style guide) or (alias pages) ? |
Co-authored-by: Alexandre ZANNI <[email protected]>
Co-authored-by: Alexandre ZANNI <[email protected]>
Co-authored-by: Alexandre ZANNI <[email protected]>
|
Uhhhhh |
|
Hello! I've noticed something unusual when checking this PR at commit
Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits. |
It's not an alias page. |
Co-authored-by: Alexandre ZANNI <[email protected]>
I've made the changes. But does it really add something to have different wordings in these similar cases ? |
|
Yes. This is a move notice of the command being grouped with another command. An alias would be if the two commands were equal. |
Managor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conversations once they are resolved.
|
#19128 have been accepted, so that's why I unresolved https://github.com/tldr-pages/tldr/pull/19096/files/8809dd7cadcfd1f70050a9806e5d0589c6589a4b and I'm still waiting for |
Signed-off-by: iTrooz <[email protected]>
noraj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
Checklist
common,linux,osx,windows,sunos,android, etc.