Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,10 @@ public void createExclusive(byte[] data)
@Override
public OutputStream create(AggregatedMemoryContext memoryContext)
{
return create(memoryContext, context.exclusiveWriteSupported());
return create(memoryContext, false);
}

public OutputStream create(AggregatedMemoryContext memoryContext, boolean exclusive)
private OutputStream create(AggregatedMemoryContext memoryContext, boolean exclusive)
{
return new S3OutputStream(memoryContext, uploadExecutor, client, context, location, exclusive, key);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,12 @@ protected final Location getRootLocation()
return Location.of("s3://%s/".formatted(bucket()));
}

@Override
protected boolean isCreateExclusive()
{
return false;
}

@Override
protected final boolean supportsRenameFile()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,6 @@ public class TestS3FileSystemS3Mock
private static final S3MockContainer S3_MOCK = new S3MockContainer("3.0.1")
.withInitialBuckets(BUCKET);

@Override
protected boolean isCreateExclusive()
{
return false; // not supported by s3-mock
}

@Override
protected boolean supportsCreateExclusive()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ default void createExclusive(byte[] data)
* <p>
* If the file already exists, the method may fail or the file may be overwritten,
* depending on the file system implementation.
* For example, S3 does not support creating files exclusively, and performing an
* For example, S3 used not to support creating files exclusively, and performing an
* existence check before creating the file is both expensive and unnecessary for
* locations that are expected to be unique.
* <p>
Expand Down
Loading