Disable existence checks in S3OutputFile.create #27330
Merged
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
approved these changes
Nov 17, 2025
Restore the behavior before as it was before support for conditional writes was introduced. File existence checks are not implemented for multi-part upload code path (the `FileAlreadyExistsException` is throw only when multi-part did not take place). Furthermore, file existence checks can break file writes when the call is retried on the AWS SDK level. Fixing both these issues is possible, but not necessary: users of `TrinoOutputFile.create` cannot assume particular behavior and file system implementation is allowed to overwrite existing files. Atomic writes are necessary for Delta's connector transaction log synchronizer `S3ConditionalWriteLogSynchronizer`, but is explicitly invokes `TrinoOutputFile.createExclusive` API.
Member
Author
|
(squashing) |
wendigo
approved these changes
Nov 17, 2025
Member
Author
|
CI (again) |
Member
Author
|
/test-with-secrets sha=2e7cdb83747248807d0b8a99a0aebd698445e66e |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/19433779789 |
findepi
added
the
no-release-notes
findepi
removed
the
no-release-notes
Member
Author
|
@chenjian2664 i reconsidered that this needs RN. Can you please add to #27153? |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the behavior before as it was before support for conditional
writes was introduced. File existence checks are not implemented for
multi-part upload code path (the
FileAlreadyExistsExceptionis throwonly when multi-part did not take place). Furthermore, file existence
checks can break file writes when the call is retried on the AWS SDK
level. Fixing both these issues is possible, but not necessary: users of
TrinoOutputFile.createcannot assume particular behavior and filesystem implementation is allowed to overwrite existing files.
Atomic writes are necessary for Delta's connector transaction log
synchronizer
S3ConditionalWriteLogSynchronizer, but is explicitlyinvokes
TrinoOutputFile.createExclusiveAPI.FileAlreadyExistsException#27400Release notes considerations
FileAlreadyExistsExceptionfailure when network failures during s3 write