[WIP] Allow users to include other configuration files. #1426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troessner
force-pushed
the
allow-users-to-include-other-configuration-files
branch
from
1292eb9 to
294e59d
Compare
|
@mvz should we allow deep nesting of inclusion? wdyt? |
mvz
reviewed
Oct 11, 2018
|
|
||
| Scenario: Other configuration file does not exist | ||
|
|
||
| Scenario: Other configuration file contains a syntax error |
There was a problem hiding this comment.
Maybe we can handle the error cases in specs instead?
Yes, I think we should probably allow it, unless it makes things more complicated. |
Yeah, I'm just gonna start out and see where it goes ;) |
|
Stale, closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part 2 of #1411