-
Notifications
You must be signed in to change notification settings - Fork 282
[WIP] Allow users to include other configuration files. #1426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
features/configuration_files/include_other_configuration_files.feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
Feature: Include other configuration files | ||
In order to give users more flexibility when it comes to configuration files | ||
we want to make it possible to include other configuration files into the main | ||
configuration file. | ||
|
||
Scenario: Include other configuration files | ||
Given a file named "smelly.rb" with: | ||
""" | ||
class Smelly # IrresponsibleModule | ||
# UncommunicativeMethodName | ||
def x(y) # UncommunicativeParameterName and UnusedParameter | ||
z = 10 # UncommunicativeVariableName | ||
end | ||
end | ||
""" | ||
And a file named ".reek.yml" with: | ||
""" | ||
--- | ||
detectors: | ||
IrresponsibleModule: | ||
enabled: false | ||
include: | ||
- second_config.yml | ||
- third_config.yml | ||
""" | ||
And a file named "second_config.yml" with: | ||
""" | ||
--- | ||
detectors: | ||
UncommunicativeMethodName: | ||
enabled: false | ||
""" | ||
And a file named "third_config.yml" with: | ||
""" | ||
--- | ||
detectors: | ||
UncommunicativeVariableName: | ||
enabled: false | ||
""" | ||
|
||
When I run reek smelly.rb | ||
Then it reports: | ||
""" | ||
smelly.rb -- 2 warnings: | ||
[3]:UncommunicativeParameterName: Smelly#x has the parameter name 'y' | ||
[3]:UnusedParameters: Smelly#x has unused parameter 'y' | ||
""" | ||
|
||
Scenario: Included file has additional include directives | ||
|
||
Scenario: Other configuration file overwrites configuration in the main configuration | ||
|
||
Scenario: Other configuration file does not exist | ||
|
||
Scenario: Other configuration file contains a syntax error | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can handle the error cases in specs instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed ;)