Skip to content

Conversation

@didoda
Copy link

@didoda didoda commented Mar 31, 2023

Hi! thanks for the awesome work you have done with ttag-cli! I am enjoying it in projects that use vuejs.

I opened this PR with the intention to provide an enhancement in vue files parsing: the parse of <template> in .vue files (as suggested in ttag-org/ttag#201).

Known issue: the extracted line numbers of the <template> part will be messed up; the reason: we put <template> extracted string after <script> extracted string, and pass it to babel.transformSync... babel function won't consider js code if it's not after import { t } from "ttag".

Bonus: github workflow that launches tests.

@didoda didoda marked this pull request as ready for review March 31, 2023 13:38
@didoda didoda changed the title Parse <template> in "vue" files parse <template> in "vue" files Mar 31, 2023
@didoda didoda marked this pull request as draft March 31, 2023 13:41
@didoda didoda marked this pull request as ready for review March 31, 2023 14:21
@AlexMost AlexMost self-assigned this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants