Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/fix mac os issues #1685

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Bug/fix mac os issues #1685

wants to merge 3 commits into from

Conversation

MaxPalmer-UH
Copy link
Contributor

@MaxPalmer-UH MaxPalmer-UH commented Mar 14, 2025

Summary

Do this PR after: #1686, as that PR is to merge into this branch (my mistake).

Fixes a few issues on my Apple Silicon MacBook

[1] Capsule hand sphere mesh was not set in the prefabs, generating errors. Not sure why this is only seen on a Mac and not in Windows,
[2] Binaries for Apple Silicon were not present and/or signed. Added these.
[3] Improved some error handling.

Contributor Tasks

  • Add a CHANGELOG entry for this change.
  • Ensure documentation requirements are met e.g., public API is commented.
  • Consider any licensing/other legal implications for this MR e.g. notices required by any new libraries.

Reviewer Tasks

  • Code reviewed.
  • Non-code assets e.g. Unity assets/scenes reviewed.
  • All tests must be ran and cover all scenarios (If not, add new tests to the cycle and run them).
  • Documentation has been reviewed.
  • Approve with a comment of any additional tests run or any observations.

Related JIRA Issues

If this MR closes any JIRA issues list them below in the form Closes PROJECT-#

Pull Request Templates

Switch template by going to preview and clicking the link - note it will not work if you've made any changes to the description.

You are currently using: default.md

Note: these links work by overwriting query parameters of the current url. If the current url contains any you may want to amend the url with &template=name.md instead of using the link. See query parameter docs for more information.

Max Palmer added 2 commits March 13, 2025 16:32
… handling. Also the capsule hand prefab(s) lost its reference to the sphere mesh, so I've reset it
…s/Tracking/Core/Runtime/Plugins/MacOS/libLeapC.5.dylib: convert to Git LFS
@rblenkinsopp
Copy link
Member

These changes look good to me, however why are the dylibs including -2 suffixes?

@rblenkinsopp rblenkinsopp self-requested a review March 20, 2025 11:02
@MaxPalmer-UH
Copy link
Contributor Author

I've tried to tidy up the libs / names. This appears to work on the Apple Silicon Mac I have but I'd appreciate someone else checking it works on theirs. Unity does some caching of the binaries sometimes.

@rblenkinsopp
Copy link
Member

I've tried to tidy up the libs / names. This appears to work on the Apple Silicon Mac I have but I'd appreciate someone else checking it works on theirs. Unity does some caching of the binaries sometimes.

Can we not lipo a single dylib for both architectures?

@MaxPalmer-UH
Copy link
Contributor Author

I originally went down that route with Peter and it seemed to become more complex than you might imagine...

Copy link
Member

@rblenkinsopp rblenkinsopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy then if alternative routes have been investigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants