-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/fix mac os issues #1685
base: develop
Are you sure you want to change the base?
Bug/fix mac os issues #1685
Conversation
… handling. Also the capsule hand prefab(s) lost its reference to the sphere mesh, so I've reset it
…s/Tracking/Core/Runtime/Plugins/MacOS/libLeapC.5.dylib: convert to Git LFS
These changes look good to me, however why are the dylibs including |
I've tried to tidy up the libs / names. This appears to work on the Apple Silicon Mac I have but I'd appreciate someone else checking it works on theirs. Unity does some caching of the binaries sometimes. |
Can we not |
I originally went down that route with Peter and it seemed to become more complex than you might imagine... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy then if alternative routes have been investigated.
Summary
Do this PR after: #1686, as that PR is to merge into this branch (my mistake).
Fixes a few issues on my Apple Silicon MacBook
[1] Capsule hand sphere mesh was not set in the prefabs, generating errors. Not sure why this is only seen on a Mac and not in Windows,
[2] Binaries for Apple Silicon were not present and/or signed. Added these.
[3] Improved some error handling.
Contributor Tasks
Reviewer Tasks
Related JIRA Issues
If this MR closes any JIRA issues list them below in the form
Closes PROJECT-#
Pull Request Templates
Switch template by going to preview and clicking the link - note it will not work if you've made any changes to the description.
You are currently using: default.md
Note: these links work by overwriting query parameters of the current url. If the current url contains any you may want to amend the url with
&template=name.md
instead of using the link. See query parameter docs for more information.