Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/fix pinch and grab detection event subscription and grab detection logic #1686

Open
wants to merge 3 commits into
base: Bug/Fix_MacOS_Issues
Choose a base branch
from

Conversation

MaxPalmer-UH
Copy link
Contributor

@MaxPalmer-UH MaxPalmer-UH commented Mar 14, 2025

Summary

Please do this before merging #1685

The PinchDetector and GrabDetector scripts were exposing properties for OnGrabStart/OnGrabbing/OnGrabEnd (same for pinch equivalents) as readonly. These could not be subscribed to.

Also the grab detection logic was inverted.

Contributor Tasks

  • Create or edit test cases here
  • Add a CHANGELOG entry for this change.
  • Ensure documentation requirements are met e.g., public API is commented.
  • Consider any licensing/other legal implications for this MR e.g. notices required by any new libraries.

Reviewer Tasks

  • Code reviewed.
  • Non-code assets e.g. Unity assets/scenes reviewed.
  • All tests must be ran and cover all scenarios (If not, add new tests to the cycle and run them).
  • Documentation has been reviewed.
  • Approve with a comment of any additional tests run or any observations.

Related JIRA Issues

If this MR closes any JIRA issues list them below in the form Closes PROJECT-#

Pull Request Templates

Switch template by going to preview and clicking the link - note it will not work if you've made any changes to the description.

You are currently using: default.md

Note: these links work by overwriting query parameters of the current url. If the current url contains any you may want to amend the url with &template=name.md instead of using the link. See query parameter docs for more information.

Max Palmer added 2 commits March 14, 2025 17:19
…le clients to subscribe to the events. Fixed grab detection internal logic which was inverted
@MaxPalmer-UH MaxPalmer-UH mentioned this pull request Mar 14, 2025
8 tasks
Copy link
Member

@rblenkinsopp rblenkinsopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this but have included some suggestions for how to make the code a little more concise and readable, will approve if you want to leave it as is however.

@MaxPalmer-UH
Copy link
Contributor Author

Happy with this but have included some suggestions for how to make the code a little more concise and readable, will approve if you want to leave it as is however.

I'll make the change. Nicer to have concise, more modern code.

@MaxPalmer-UH
Copy link
Contributor Author

@rblenkinsopp I've pushed those changes now.

Copy link
Member

@rblenkinsopp rblenkinsopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants