-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/fix pinch and grab detection event subscription and grab detection logic #1686
base: Bug/Fix_MacOS_Issues
Are you sure you want to change the base?
Conversation
…le clients to subscribe to the events. Fixed grab detection internal logic which was inverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this but have included some suggestions for how to make the code a little more concise and readable, will approve if you want to leave it as is however.
Packages/Tracking/Core/Runtime/Scripts/ActionDetectors/GrabDetector.cs
Outdated
Show resolved
Hide resolved
Packages/Tracking/Core/Runtime/Scripts/ActionDetectors/PinchDetector.cs
Outdated
Show resolved
Hide resolved
I'll make the change. Nicer to have concise, more modern code. |
@rblenkinsopp I've pushed those changes now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this now
Summary
Please do this before merging #1685
The PinchDetector and GrabDetector scripts were exposing properties for OnGrabStart/OnGrabbing/OnGrabEnd (same for pinch equivalents) as readonly. These could not be subscribed to.
Also the grab detection logic was inverted.
Contributor Tasks
Reviewer Tasks
Related JIRA Issues
If this MR closes any JIRA issues list them below in the form
Closes PROJECT-#
Pull Request Templates
Switch template by going to preview and clicking the link - note it will not work if you've made any changes to the description.
You are currently using: default.md
Note: these links work by overwriting query parameters of the current url. If the current url contains any you may want to amend the url with
&template=name.md
instead of using the link. See query parameter docs for more information.