Skip to content

Update vms、setting、tools#157

Open
ggggeeee wants to merge 3 commits into
unraid:masterfrom
ggggeeee:master
Open

Update vms、setting、tools#157
ggggeeee wants to merge 3 commits into
unraid:masterfrom
ggggeeee:master

Conversation

@ggggeeee

@ggggeeee ggggeeee commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

Update vms, settings, and tools to remove ineffective or untranslated text and correct capitalization.

Summary by CodeRabbit

  • Documentation
    • Updated error messages for CPU pinning configuration
    • Enhanced multilingual UI labels and instruction text
    • Revised special character documentation with localized translations

✏️ Tip: You can customize this high-level summary in your review settings.

Updated the special characters validity message to Chinese.
Corrected translations for CPU pinning messages in settings.
@coderabbitai

coderabbitai Bot commented Jan 8, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Three configuration files receive localization updates: error message punctuation adjustments in settings.txt, UI text localization in tools.txt, and English-to-Chinese translation for special character documentation in vms.txt. No functional logic changes.

Changes

Cohort / File(s) Summary
Configuration Text Localization
settings.txt
Removed periods from CPU pinning error messages and updated corresponding Chinese translations to align with English punctuation changes.
Configuration Text Localization
tools.txt
Updated webGUI label capitalization ("web图形界面" → "Web图形界面") and replaced English instruction text with Chinese translation for key file URL handling.
Configuration Text Localization
vms.txt
Translated English specification of valid special characters into Chinese with corresponding punctuation and formatting adjustments.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • Update vms.txt #153: Updates vms.txt with Chinese localization changes to the same configuration file.

Poem

🐰 Across the config files we hop,
Translations dance without a stop,
Period removed, punctuation neat,
Chinese strings and English meet,
Localization now complete! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and uses non-descriptive formatting with Chinese punctuation and file names without conveying what the actual changes accomplish. Use a more descriptive title that clearly summarizes the main objective, such as 'Localize CPU pinning and special character messages to Chinese' or 'Add Chinese translations and fix capitalization in localization files'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In @settings.txt:
- Around line 506-507: The English strings "No CPU pinning available Docker
service must be started" and "No CPU pinning available VM service must be
started" are missing punctuation between clauses; update these two entries to
include proper separation (e.g., "No CPU pinning available. Docker service must
be started." and "No CPU pinning available. VM service must be started." or use
an em dash) so the sentences are grammatically correct and readable while
keeping the Chinese translations unchanged.

In @vms.txt:
- Line 132: The file uses two different Chinese translations for "Period" ("句号"
at the occurrence shown and "句点" elsewhere); standardize terminology by
replacing all occurrences of "句点" with "句号" so the translation for "Period" is
consistent across the file, and verify other punctuation names match this
convention.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 52fa7c0 and 5cc2c29.

📒 Files selected for processing (3)
  • settings.txt
  • tools.txt
  • vms.txt
🔇 Additional comments (1)
tools.txt (1)

172-173: Localization changes look good.

The capitalization fix in Line 172 ("web" → "Web") is appropriate for UI consistency. The Chinese translation in Line 173 properly preserves formatting tags and accurately conveys the instruction. No concerns.

Comment thread settings.txt
Comment on lines +506 to +507
No CPU pinning available Docker service must be started=没有可绑定的 CPU必须先启动 Docker 服务
No CPU pinning available VM service must be started=没有可绑定的 CPU必须先启动虚拟机服务

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

English grammar issue: Missing punctuation between clauses.

The removal of the period creates grammatically incorrect English text: "No CPU pinning available Docker service must be started." This needs punctuation or restructuring to be readable. Consider:

  • "No CPU pinning available. Docker service must be started." (period)
  • "No CPU pinning available—Docker service must be started." (em dash)
  • Other restructuring to clarify the relationship between the two clauses

The Chinese translation works fine with a comma, but the English requires proper punctuation to be grammatically correct and user-friendly.

🤖 Prompt for AI Agents
In @settings.txt around lines 506 - 507, The English strings "No CPU pinning
available Docker service must be started" and "No CPU pinning available VM
service must be started" are missing punctuation between clauses; update these
two entries to include proper separation (e.g., "No CPU pinning available.
Docker service must be started." and "No CPU pinning available. VM service must
be started." or use an em dash) so the sentences are grammatically correct and
readable while keeping the Chinese translations unchanged.

Comment thread vms.txt
Not running=没有运行
Not set=未设置
Only these special characters are valid Underscore _ Hyphen - Colon Period=Only these special characters are valid Underscore (_) Hyphen (-) Colon (:) Period (.)
Only these special characters are valid Underscore _ Hyphen - Colon Period=只有以下特殊字符有效:下划线 (_) 、连字符 (-) 、冒号 (:) 、句号 (.)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Inconsistent Chinese terminology for "Period" across the file.

Line 132 uses "句号" to translate "Period," but Line 286 uses "句点" for the same English word in a similar context. Maintain consistency by using the same Chinese term throughout the file; "句号" is the more standard/common choice for punctuation terminology.

🤖 Prompt for AI Agents
In @vms.txt at line 132, The file uses two different Chinese translations for
"Period" ("句号" at the occurrence shown and "句点" elsewhere); standardize
terminology by replacing all occurrences of "句点" with "句号" so the translation
for "Period" is consistent across the file, and verify other punctuation names
match this convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant