Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install aptly 1.6.0 on debian bookworm #20

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

neolynx
Copy link

@neolynx neolynx commented Jan 11, 2025

I saw you updated to aptly 1.6.0, but the pipeline failed, as we changed the repos.

This change includes the following:

  • based on debian:bookworm-slim
  • install from new repos
  • cleanup and reduce image size

- based on debian:bookworm-slim
- install from new repos
- cleanup and reduce image size
@urpylka
Copy link
Owner

urpylka commented Jan 13, 2025

Hi thank you for the MR. I am going to merge it. But why do you delete installing completions?

- ADD https://raw.githubusercontent.com/aptly-dev/aptly/v1.6.0/completion.d/aptly /usr/share/bash-completion/completions/aptly

@neolynx
Copy link
Author

neolynx commented Jan 13, 2025

Hi thank you for the MR. I am going to merge it. But why do you delete installing completions?

- ADD https://raw.githubusercontent.com/aptly-dev/aptly/v1.6.0/completion.d/aptly /usr/share/bash-completion/completions/aptly

because the completion is already in the aptly debian package, it should not be needed. does the completion work without downloading it additionally ? otherwise we would need to fix the package...

we could also think about moving your repo to aptly-dev, and have the docker container generated automatically when aptly is released (maybe for both prod and ci builds). what do you think ?

@neolynx neolynx closed this Jan 13, 2025
@urpylka
Copy link
Owner

urpylka commented Jan 13, 2025

Yes, I thinks it is a good idea. As it is project can be maintained by the community better than now.

@urpylka urpylka reopened this Jan 13, 2025
@urpylka urpylka merged commit beae90a into urpylka:master Jan 13, 2025
2 checks passed
@urpylka urpylka mentioned this pull request Jan 30, 2025
agibalovsa added a commit to agibalovsa/aptly that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants