Implement Collatz Conjecture Tower#57
Open
IHIHHIHI wants to merge 7 commits into
Open
Conversation
Collaborator
Author
|
|
IHIHHIHI
commented
Jan 1, 2023
| } | ||
| else | ||
| { | ||
| damage = -(health.curAmount * 2 + 1); |
Collaborator
Author
There was a problem hiding this comment.
음수 데미지가 바람직한 방식인지는 모르겠습니다.
Owner
There was a problem hiding this comment.
구현 방향을 정하기 나름일 거 같은데, 패널티를 어떻게 주고 싶음?
데미지를 0으로 만들기 또는 체력을 오히려 회복하기
Owner
There was a problem hiding this comment.
흠... 데미지를 -로 주는 건 체력을 회복하는 의도와는 맞지 않으니, 별도로 체력을 회복하는 로직을 넣는게 좋겠다고 생각해. GiveDamage()가 아닌 TakeHeal()라는 이름의 함수를 하나 만들어서 처리합시다.
utilForever
requested changes
Jan 1, 2023
Owner
utilForever
left a comment
utilForever
left a comment
There was a problem hiding this comment.
Looks good to me except some code. Can you check my comments? Thanks. 🌆
| } | ||
| else | ||
| { | ||
| damage = -(health.curAmount * 2 + 1); |
Owner
There was a problem hiding this comment.
구현 방향을 정하기 나름일 거 같은데, 패널티를 어떻게 주고 싶음?
데미지를 0으로 만들기 또는 체력을 오히려 회복하기
Co-authored-by: Chris Ohk <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
콜라츠 추측 타워를 구현하는 것이 목표인 PR입니다.
추가적인 해야 할 일은 다음과 같습니다.