-
Notifications
You must be signed in to change notification settings - Fork 8
Implement Collatz Conjecture Tower #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IHIHHIHI
wants to merge
7
commits into
main
Choose a base branch
from
tower/collatz
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7c78473
Add Collatz Damage Component and add function OncollideCollatz
IHIHHIHI 4b36830
Add CreateCollatz Function
IHIHHIHI 43112d0
Add ShootCollatz Function
IHIHHIHI 7b5c806
Add BuyCollatzTower function
IHIHHIHI fbbfb55
Add Button for Collatz Tower
IHIHHIHI d568a2f
Remove Health component
IHIHHIHI 2fa6f30
Apply suggestions from code review
IHIHHIHI File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // Copyright (c) 2021 CubbyTower Team | ||
| // Chris Ohk, Minkyu Lee, Minjune Yi | ||
| // We are making my contributions/submissions to this project solely in our | ||
| // personal capacity and are not conveying any rights to any intellectual | ||
| // property of any third parties. | ||
|
|
||
| #ifndef CUBBYTOWER_COLLATZ_DAMAGE_HPP | ||
| #define CUBBYTOWER_COLLATZ_DAMAGE_HPP | ||
|
|
||
| namespace CubbyTower | ||
| { | ||
| //! | ||
| //! \brief Damage struct for Collatz tower. | ||
| //! | ||
| //! This struct stores the max damage of the tower. | ||
| //! | ||
| struct CollatzDamage | ||
| { | ||
| int maxDamage; | ||
| }; | ||
| } // namespace CubbyTower | ||
|
|
||
| #endif // CUBBYTOWER_COLLATZ_DAMAGE_HPP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음수 데미지가 바람직한 방식인지는 모르겠습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
구현 방향을 정하기 나름일 거 같은데, 패널티를 어떻게 주고 싶음?
데미지를 0으로 만들기 또는 체력을 오히려 회복하기
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
회복하는게 의도입니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
흠... 데미지를 -로 주는 건 체력을 회복하는 의도와는 맞지 않으니, 별도로 체력을 회복하는 로직을 넣는게 좋겠다고 생각해.
GiveDamage()가 아닌TakeHeal()라는 이름의 함수를 하나 만들어서 처리합시다.