Use spacewalk-hostname-rename from uyuni-update-config service #10352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires uyuni-project/uyuni-tools#582 |
3 tasks
Watch out for UYUNI_HOSTNAME value change before starting services and rename the server if needed. (bsc#1229825) In order to achieve this, the spacewalk-hostname-rename script had to be cleaned up.
|
Note that I pondered moving the |
mcalmer
requested changes
May 17, 2025
| @@ -186,14 +188,32 @@ def change_billing_data_service(): | |||
| sys.stdout.write("billing-data-service sysconfig: changed LISTEN address\n") | |||
|
|
|||
|
|
|||
| def hostname_check(): | |||
There was a problem hiding this comment.
This function should not be named 'check' when it change something.
|
@cbosdo could you elaborate on why to put it on the uyuni startup service instead of calling the command directly from mgradm? |
rjmateus
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Watch out for UYUNI_HOSTNAME value change before starting services and rename the server if needed. (bsc#1229825)
In order to achieve this, the spacewalk-hostname-rename script had to be cleaned up.
GUI diff
No difference.
Documentation
Documentation PR
DONE
Test coverage
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/24412 https://github.com/SUSE/spacewalk/issues/25448
Port(s): # add downstream PR(s), if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!