fix(daily): cover traffic leaking channels - #2407
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2407 +/- ##
==========================================
- Coverage 73.98% 73.97% -0.02%
==========================================
Files 168 168
Lines 22079 22079
Branches 19 19
==========================================
- Hits 16336 16332 -4
- Misses 5743 5747 +4 🚀 New features to boost your workflow:
|
gmelodie
enabled auto-merge (squash)
May 5, 2026 14:49
vladopajic
approved these changes
May 5, 2026
vladopajic
left a comment
vladopajic
left a comment
Member
There was a problem hiding this comment.
FYI #2378 mix is not here anymore
richard-ramos
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cover traffic integration tests were leaking channels. The
slot exhaustiontest now stops mix nodes before destNode. Previously (LIFO defer order), destNode stopped first, leaving in-flight exit→destNode channels in a partially-open state when the mix nodes' switches finally cleaned up.References