-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(axiom): add support for regional edge endpoints in AxiomConfig #24037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(axiom): add support for regional edge endpoints in AxiomConfig #24037
Conversation
c448a3c to
06e0f8e
Compare
Introduces optional `region` field for regional edge domains and enhances `url` field with intelligent path detection. URLs with custom paths are used as-is, while URLs without paths maintain backwards compatibility by appending the legacy path format. Priority: url > region > default cloud endpoint Fully backwards compatible with existing configurations.
06e0f8e to
9bf1a13
Compare
ronoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good !
|
Hey @jszwedko can I get a review on this please, we're hoping to get this into the next release |
- Moved the Axiom sink configuration and integration tests to a new module `axiom` under the `sinks` directory. - Implemented `UrlOrRegion` struct to manage Axiom endpoint configurations, ensuring validation between URL and region settings. - Moved the integration tests to a new module `integration_tests` under the `axiom` module. - Updated documentation for the Axiom sink configuration in the generated CUE files to reflect new fields and usage examples.
pront
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @toppercodes
Co-authored-by: domalessi <[email protected]>
|
@pront Is there any other actions required from my side? |
As long as the tests pass, this is good to go. |
Head branch was pushed to by a user without write access
Tests should be passing now |
…ectordotdev#24037) * feat(axiom sink): Add regional edge support with smart URL handling Introduces optional `region` field for regional edge domains and enhances `url` field with intelligent path detection. URLs with custom paths are used as-is, while URLs without paths maintain backwards compatibility by appending the legacy path format. Priority: url > region > default cloud endpoint Fully backwards compatible with existing configurations. * cargo fmt * refactor(axiom): Axiom sink configuration and integration tests - Moved the Axiom sink configuration and integration tests to a new module `axiom` under the `sinks` directory. - Implemented `UrlOrRegion` struct to manage Axiom endpoint configurations, ensuring validation between URL and region settings. - Moved the integration tests to a new module `integration_tests` under the `axiom` module. - Updated documentation for the Axiom sink configuration in the generated CUE files to reflect new fields and usage examples. * cargo fmt * fix(axiom): Update integration tests to include SinkConfig and UrlOrRegion * Update website/cue/reference/components/sinks/generated/axiom.cue Co-authored-by: domalessi <[email protected]> * fix: Fix wording * fix(axiom): Make AxiomConfig fields public --------- Co-authored-by: Pavlos Rontidis <[email protected]> Co-authored-by: domalessi <[email protected]>
…ectordotdev#24037) * feat(axiom sink): Add regional edge support with smart URL handling Introduces optional `region` field for regional edge domains and enhances `url` field with intelligent path detection. URLs with custom paths are used as-is, while URLs without paths maintain backwards compatibility by appending the legacy path format. Priority: url > region > default cloud endpoint Fully backwards compatible with existing configurations. * cargo fmt * refactor(axiom): Axiom sink configuration and integration tests - Moved the Axiom sink configuration and integration tests to a new module `axiom` under the `sinks` directory. - Implemented `UrlOrRegion` struct to manage Axiom endpoint configurations, ensuring validation between URL and region settings. - Moved the integration tests to a new module `integration_tests` under the `axiom` module. - Updated documentation for the Axiom sink configuration in the generated CUE files to reflect new fields and usage examples. * cargo fmt * fix(axiom): Update integration tests to include SinkConfig and UrlOrRegion * Update website/cue/reference/components/sinks/generated/axiom.cue Co-authored-by: domalessi <[email protected]> * fix: Fix wording * fix(axiom): Make AxiomConfig fields public --------- Co-authored-by: Pavlos Rontidis <[email protected]> Co-authored-by: domalessi <[email protected]>
|
Hi @pront can you please confirm if this was included in the 0.51.1 release? Thanks. |
👋 Since the PR was merged after v0.51.1, it will be included in the next release (likely v0.52.0 or similar). |
Summary
Axiom is working on adding regional ingest endpoints.
This PR introduces a new
regionfield inAxiomConfigto specify the Axiom regional edge domain for data ingestion, and enhances theurlfield with intelligent path detection.Configuration priority:
url>region> default cloud endpointKey features:
region: Domain-only format (e.g.,mumbai.axiom.co) - automatically buildshttps://{region}/v1/ingest/{dataset}url: Smart path handling/v1/datasets/{dataset}/ingestVector configuration
Using regional edge:
Using URL with custom path (super special case):
Using URL without path (backwards compatible):
Traditional configuration (unchanged):
URL takes precedence over region:
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.Changelog fragment added:
changelog.d/axiom_regional_edges.feature.mdReferences
Closes #24038
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.