fix: do not kill external Chrome on CDP disconnect (#539)#540
Open
RussellZager wants to merge 2 commits intovercel-labs:mainfrom
Open
fix: do not kill external Chrome on CDP disconnect (#539)#540RussellZager wants to merge 2 commits intovercel-labs:mainfrom
RussellZager wants to merge 2 commits intovercel-labs:mainfrom
Conversation
- Introduce `safelyDisconnectCdp` helper in `BrowserManager` to close the underlying WebSocket connection instead of sending `Browser.close` command. - Use `safelyDisconnectCdp` in `connectViaCDP` error handler and `BrowserManager.close` when connected via CDP. - This prevents the external Chrome process from being killed when `agent-browser` disconnects or encounters an error during connection. Fixes vercel-labs#539 Co-authored-by: Zman771 <605281+Zman771@users.noreply.github.com>
…80412380299 fix(cdp): prevent browser termination on CDP disconnect
Contributor
|
@RussellZager is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced browser.close() with browser.disconnect() for CDP/remote sessions so the external browser is not terminated.