Skip to content

fix: do not kill external Chrome on CDP disconnect (#539) #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RussellZager wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: do not kill external Chrome on CDP disconnect (#539) #540

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
872d5d3
fix(cdp): prevent browser termination on CDP disconnect
google-labs-jules[bot] Feb 25, 2026
2b58ada
Merge pull request #1 from RussellZager/fix-cdp-browser-kill-47615643…
RussellZager Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1415,6 +1415,20 @@ export class BrowserManager {
this.activePageIndex = this.pages.length > 0 ? this.pages.length - 1 : 0;
}

/**
* Safely disconnect from a CDP session without closing the external browser process.
* Playwright's browser.close() sends Browser.close command which kills the process.
* Accessing the underlying connection allows us to just close the WebSocket.
*/
private async safelyDisconnectCdp(browser: Browser): Promise<void> {
const b = browser as any;
if (b._connection && typeof b._connection.close === 'function') {
b._connection.close();
} else {
await browser.close().catch(() => {});
}
}

/**
* Connect to a running browser via CDP (Chrome DevTools Protocol)
* @param cdpEndpoint Either a port number (as string) or a full WebSocket URL (ws:// or wss://)
Expand Down Expand Up @@ -1490,7 +1504,7 @@ export class BrowserManager {
this.activePageIndex = 0;
} catch (error) {
// Clean up browser connection if validation or setup failed
await browser.close().catch(() => {});
await this.safelyDisconnectCdp(browser);
throw error;
}
}
Expand Down Expand Up @@ -2444,7 +2458,7 @@ export class BrowserManager {
} else if (this.cdpEndpoint !== null) {
// CDP: only disconnect, don't close external app's pages
if (this.browser) {
await this.browser.close().catch(() => {});
await this.safelyDisconnectCdp(this.browser);
this.browser = null;
}
} else {
Expand Down