fix: approve smoke-test release PR before downstream release#431
Merged
c-vigo merged 2 commits intorelease/0.3.1from Mar 24, 2026
Merged
fix: approve smoke-test release PR before downstream release#431c-vigo merged 2 commits intorelease/0.3.1from
c-vigo merged 2 commits intorelease/0.3.1from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes smoke-test release orchestration by ensuring the downstream release validation gate (reviewDecision == APPROVED) can be satisfied automatically before release.yml is dispatched.
Changes:
- Grant
pull-requests: writeon theready-release-prjob in the smoke-testrepository_dispatchworkflow. - Add a step to approve the release PR using
github.token(github-actions[bot]) sorelease-core.ymlapproval checks pass without manual intervention. - Document the fix in both the root changelog and the workspace template changelog.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| assets/smoke-test/.github/workflows/repository-dispatch.yml | Adds job-scoped permissions and an automated PR approval step prior to triggering release.yml. |
| CHANGELOG.md | Records the smoke-test approval fix under the 0.3.1 release-branch section. |
| assets/workspace/.devcontainer/CHANGELOG.md | Mirrors the changelog entry into the workspace template. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Smoke-test
repository_dispatchorchestration marks the release PR ready and dispatchesrelease.yml, butrelease-core.ymlrequiresreviewDecision == APPROVED. The release app cannot self-approve its own PR. This PR adds aready-release-prjob step that approves the release PR usinggithub.token, with job-scopedpull-requests: write, so downstream Release Core validation passes without manual approval.Type of Change
fix-- Bug fixfeat-- New featuredocs-- Documentation onlychore-- Maintenance task (deps, config, etc.)refactor-- Code restructuring (no behavior change)test-- Adding or updating testsci-- CI/CD pipeline changesbuild-- Build system or dependency changesrevert-- Reverts a previous commitstyle-- Code style (formatting, whitespace)Modifiers
!) -- This change breaks backward compatibilityChanges Made
assets/smoke-test/.github/workflows/repository-dispatch.ymlpermissions: contents: readandpull-requests: writeon jobready-release-pr.GH_TOKEN: ${{ github.token }}andgh pr review … --approveafter release-kind labeling.CHANGELOG.md/assets/workspace/.devcontainer/CHANGELOG.md## [0.3.1] - TBD→### Fixed(#430).Changelog Entry
This PR targets
release/0.3.1; the active section is## [0.3.1] - TBD(not## Unreleased). Added under### Fixed:Testing
just test)Manual Testing Details
N/A — workflow change; verify on next smoke-test dispatch after template is deployed to
devcontainer-smoke-test.Checklist
docs/templates/, then runjust docs)CHANGELOG.mdin the[Unreleased]section (and pasted the entry above)Additional Notes
Base branch:
release/0.3.1. Changelog entries are under## [0.3.1] - TBD(release branch), not## Unreleased— the template checklist item above is left unchecked for that reason.Branch protection on the smoke-test repo must allow
git*hub-actions[bot]reviews to count toward required approvals if applicable.Refs: #430