Skip to content

fix: approve smoke-test release PR before downstream release#431

Merged
c-vigo merged 2 commits intorelease/0.3.1from
bugfix/430-smoke-test-dispatch-failed
Mar 24, 2026
Merged

fix: approve smoke-test release PR before downstream release#431
c-vigo merged 2 commits intorelease/0.3.1from
bugfix/430-smoke-test-dispatch-failed

Conversation

@c-vigo
Copy link
Contributor

@c-vigo c-vigo commented Mar 24, 2026

Description

Smoke-test repository_dispatch orchestration marks the release PR ready and dispatches release.yml, but release-core.yml requires reviewDecision == APPROVED. The release app cannot self-approve its own PR. This PR adds a ready-release-pr job step that approves the release PR using github.token, with job-scoped pull-requests: write, so downstream Release Core validation passes without manual approval.

Type of Change

  • fix -- Bug fix
  • feat -- New feature
  • docs -- Documentation only
  • chore -- Maintenance task (deps, config, etc.)
  • refactor -- Code restructuring (no behavior change)
  • test -- Adding or updating tests
  • ci -- CI/CD pipeline changes
  • build -- Build system or dependency changes
  • revert -- Reverts a previous commit
  • style -- Code style (formatting, whitespace)

Modifiers

  • Breaking change (!) -- This change breaks backward compatibility

Changes Made

  • assets/smoke-test/.github/workflows/repository-dispatch.yml
    • Set permissions: contents: read and pull-requests: write on job ready-release-pr.
    • Add step Approve release PR for automated dispatch using GH_TOKEN: ${{ github.token }} and gh pr review … --approve after release-kind labeling.
  • CHANGELOG.md / assets/workspace/.devcontainer/CHANGELOG.md
    • Document fix under ## [0.3.1] - TBD### Fixed (#430).

Changelog Entry

This PR targets release/0.3.1; the active section is ## [0.3.1] - TBD (not ## Unreleased). Added under ### Fixed:

- **Smoke-test dispatch approves release PR before downstream release** ([#430](https://github.com/vig-os/devcontainer/issues/430))
  - Grant `pull-requests: write` on `ready-release-pr` and approve with `github.token` (`git*hub-actions[bot]`)
  - Satisfy `release-core.yml` approval gate without the release app self-approving its own PR

Testing

  • Tests pass locally (just test)
  • Manual testing performed (describe below)

Manual Testing Details

N/A — workflow change; verify on next smoke-test dispatch after template is deployed to devcontainer-smoke-test.

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly (edit docs/templates/, then run just docs)
  • I have updated CHANGELOG.md in the [Unreleased] section (and pasted the entry above)
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Additional Notes

Base branch: release/0.3.1. Changelog entries are under ## [0.3.1] - TBD (release branch), not ## Unreleased — the template checklist item above is left unchecked for that reason.

Branch protection on the smoke-test repo must allow git*hub-actions[bot] reviews to count toward required approvals if applicable.

Refs: #430

@c-vigo c-vigo self-assigned this Mar 24, 2026
@c-vigo c-vigo requested a review from Copilot March 24, 2026 15:46
@c-vigo c-vigo changed the title fix: approve smoke-test release PR before downstream release bugfix: approve smoke-test release PR before downstream release Mar 24, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes smoke-test release orchestration by ensuring the downstream release validation gate (reviewDecision == APPROVED) can be satisfied automatically before release.yml is dispatched.

Changes:

  • Grant pull-requests: write on the ready-release-pr job in the smoke-test repository_dispatch workflow.
  • Add a step to approve the release PR using github.token (github-actions[bot]) so release-core.yml approval checks pass without manual intervention.
  • Document the fix in both the root changelog and the workspace template changelog.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
assets/smoke-test/.github/workflows/repository-dispatch.yml Adds job-scoped permissions and an automated PR approval step prior to triggering release.yml.
CHANGELOG.md Records the smoke-test approval fix under the 0.3.1 release-branch section.
assets/workspace/.devcontainer/CHANGELOG.md Mirrors the changelog entry into the workspace template.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@c-vigo c-vigo changed the title bugfix: approve smoke-test release PR before downstream release fix: approve smoke-test release PR before downstream release Mar 24, 2026
@c-vigo c-vigo enabled auto-merge March 24, 2026 15:58
@c-vigo c-vigo merged commit 27b1289 into release/0.3.1 Mar 24, 2026
12 of 14 checks passed
@c-vigo c-vigo deleted the bugfix/430-smoke-test-dispatch-failed branch March 24, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants