Skip to content

fix: approve smoke-test release PR before downstream release #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c-vigo merged 2 commits into from
Mar 24, 2026
Merged

fix: approve smoke-test release PR before downstream release #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f8109e
fix(ci): approve release PR with GITHUB_TOKEN before release dispatch
c-vigo Mar 24, 2026
b451a2e
ci: strict shell and approval failure hint in dispatch approve step
c-vigo Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Update `tests/test_image.py` `EXPECTED_VERSIONS["uv"]` to match uv 0.11.x from the latest release install path in the image build
- **Container image tests expect current just minor line** ([#423](https://github.com/vig-os/devcontainer/issues/423))
- Update `tests/test_image.py` `EXPECTED_VERSIONS["just"]` to match just 1.48.x from the latest release install path in the image build
- **Smoke-test dispatch approves release PR before downstream release** ([#430](https://github.com/vig-os/devcontainer/issues/430))
- Grant `pull-requests: write` on `ready-release-pr` and approve with `github.token` (`github-actions[bot]`)
- Satisfy `release-core.yml` approval gate without the release app self-approving its own PR

### Security

Expand Down
15 changes: 15 additions & 0 deletions assets/smoke-test/.github/workflows/repository-dispatch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,9 @@ jobs:
name: Prepare release PR
runs-on: ubuntu-22.04
timeout-minutes: 35
permissions:
contents: read
pull-requests: write
env:
GH_REPO: ${{ github.repository }}
needs: [validate, trigger-prepare-release]
Expand Down Expand Up @@ -545,6 +548,18 @@ jobs:
gh pr edit "${PR_NUMBER}" --remove-label "release-kind:final" >/dev/null 2>&1 || true
gh pr edit "${PR_NUMBER}" --add-label "${LABEL}"

- name: Approve release PR for automated dispatch
env:
GH_TOKEN: ${{ github.token }}
PR_NUMBER: ${{ steps.locate_release_pr.outputs.release_pr }}
run: |
set -euo pipefail
gh pr review "${PR_NUMBER}" --approve \
--body "Automated approval by smoke-test dispatch orchestration." || {
echo "::error::Auto-approve failed. If you see a permissions error, enable repository (or organization) setting 'Allow GitHub Actions to create and approve pull requests'. See this PR description for context."
exit 1
}

trigger-release:
name: Trigger and wait for release workflow
runs-on: ubuntu-22.04
Expand Down
3 changes: 3 additions & 0 deletions assets/workspace/.devcontainer/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Update `tests/test_image.py` `EXPECTED_VERSIONS["uv"]` to match uv 0.11.x from the latest release install path in the image build
- **Container image tests expect current just minor line** ([#423](https://github.com/vig-os/devcontainer/issues/423))
- Update `tests/test_image.py` `EXPECTED_VERSIONS["just"]` to match just 1.48.x from the latest release install path in the image build
- **Smoke-test dispatch approves release PR before downstream release** ([#430](https://github.com/vig-os/devcontainer/issues/430))
- Grant `pull-requests: write` on `ready-release-pr` and approve with `github.token` (`github-actions[bot]`)
- Satisfy `release-core.yml` approval gate without the release app self-approving its own PR

### Security

Expand Down
Loading