Modernized type hints and pattern matching in core/helpers.py

[siddhaka]

This PR updates llmcompressor/core/helpers.py to use Python 3.10+ features for improved readability and consistency.

No functional changes were made.
Verified with local tests.

[github-actions]

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

[gemini-code-assist]

Summary of Changes

Hello @siddhaka, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the llmcompressor/core/helpers.py file by adopting contemporary Python 3.10+ features. The changes primarily involve updating type hint syntax and refactoring a conditional block into a pattern matching statement. The aim is to enhance code readability and align with modern Python best practices without altering any existing functionality.

Highlights

• Type Hint Modernization: Updated type hints to leverage Python 3.10+ syntax, replacing Optional[X] with X | None and Union[X, Y] with X | Y for improved readability and conciseness.
• Pattern Matching Implementation: Replaced an if/elif/else block with a match/case statement in _log_model_loggable_items for more expressive and readable control flow when handling different data types.
• No Functional Changes: Confirmed that these updates are purely stylistic and do not introduce any functional changes to the existing codebase, maintaining current behavior.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully modernizes the type hints and introduces pattern matching in core/helpers.py, which improves readability and aligns the code with Python 3.10+ features. I've included a few suggestions to enhance type safety and code clarity by adding missing return type hints and ensuring that values passed to logging functions match their expected types.

[brian-dellabetta]

thanks for the contribution, lgtm