Skip to content

Modernized type hints and pattern matching in core/helpers.py #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2025
+11 −12
Merged

Modernized type hints and pattern matching in core/helpers.py #1933

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82d24bd
Fixed buff format changes
siddhaka Oct 15, 2025
1ff3059
Merge branch 'main' into core-modernization
rahul-tuli Oct 22, 2025
a6ed347
Merge branch 'main' into core-modernization
brian-dellabetta Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions src/llmcompressor/core/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
conditional logging and parameter tracking.
"""

from typing import Any, Generator, Optional, Tuple, Union
from typing import Any, Generator

from llmcompressor.core.state import State
from llmcompressor.metrics import LoggerManager
Expand All @@ -21,7 +21,7 @@ def should_log_model_info(
model: Any,
loggers: LoggerManager,
current_log_step: float,
last_log_step: Optional[float] = None,
last_log_step: float | None = None,
) -> bool:
"""
Check if we should log model level info
Expand Down Expand Up @@ -65,9 +65,7 @@ def log_model_info(state: State, current_log_step):
)


def _log_current_step(
logger_manager: LoggerManager, current_log_step: Union[float, int]
):
def _log_current_step(logger_manager: LoggerManager, current_log_step: float | int):
"""
Log the Current Log Step to the logger_manager

Expand All @@ -80,7 +78,7 @@ def _log_current_step(

def _log_model_loggable_items(
logger_manager: LoggerManager,
loggable_items: Generator[Tuple[str, Any], None, None],
loggable_items: Generator[tuple[str, Any], None, None],
epoch: float,
):
"""
Expand All @@ -93,9 +91,10 @@ def _log_model_loggable_items(
"""
for loggable_item in loggable_items:
log_tag, log_value = loggable_item
if isinstance(log_value, dict):
logger_manager.log_scalars(tag=log_tag, values=log_value, step=epoch)
elif isinstance(log_value, (int, float)):
logger_manager.log_scalar(tag=log_tag, value=log_value, step=epoch)
else:
logger_manager.log_string(tag=log_tag, string=log_value, step=epoch)
match log_value:
case dict():
logger_manager.log_scalars(tag=log_tag, values=log_value, step=epoch)
case int() | float():
logger_manager.log_scalar(tag=log_tag, value=log_value, step=epoch)
case _:
logger_manager.log_string(tag=log_tag, string=log_value, step=epoch)