Change default drafter architecture from Llama to Qwen3 - #620
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Orestis Zambounis <orestis.zambounis@gmail.com>
8621e97 to
b75682e
Compare
shanjiaz
left a comment
There was a problem hiding this comment.
Looks good! Let's hold off landing this and wait for Ben's PR on vllm's side to land first?
rahul-tuli
left a comment
There was a problem hiding this comment.
LGTM, we'll land once the blocking PR is in
totally yes! |
|
On the same note of arch improvement, I recommend adopting the EAGLE3.1 setup: use separate norms on each of the input features before projecting, and use the post-norm hidden state into subsequent draft/TTT steps. Example checkpoint here: https://huggingface.co/lightseekorg/kimi-k2.6-eagle3.1-mla It is supported in vLLM for both Llama and Qwen3-based EAGLE drafters |
Thanks for your suggestion @benchislett. Totally agree and I have this WIP to support 3.1 setup: #610. And thanks for the checkpoint. |
|
@rahul-tuli @shanjiaz no more blockers, ready to land? |
|
All links are now valid - this issue has been resolved. Marked as resolved: 7b2f765 |
PR vllm-project#620 changed the argparse default to qwen3 but missed the function-level default in create_transformer_layer_config and left a warning that now fires on every default training run. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Orestis Zambounis <orestis.zambounis@gmail.com>
Summary
--draft-arch) and Eagle3 config (transformer_layer_config)Blocked by
Jira
Test plan
--draft-archdefaults toqwen3when not specifiedEagle3SpeculatorConfigusesQwen3Configas defaulttransformer_layer_config🤖 Generated with Claude Code