Skip to content

Change default drafter architecture from Llama to Qwen3 - #620

Merged
shanjiaz merged 3 commits into
mainfrom
qwen3-default-drafter-arch
Jun 22, 2026
Merged

Change default drafter architecture from Llama to Qwen3#620
shanjiaz merged 3 commits into
mainfrom
qwen3-default-drafter-arch

Conversation

@orestis-z

Copy link
Copy Markdown
Collaborator

Summary

  • Change the default drafter architecture from Llama to Qwen3 in the training script (--draft-arch) and Eagle3 config (transformer_layer_config)
  • Qwen3 is now the recommended default for new speculator training

Blocked by

Jira

Test plan

  • Verify --draft-arch defaults to qwen3 when not specified
  • Verify Eagle3SpeculatorConfig uses Qwen3Config as default transformer_layer_config
  • Run training with default args and confirm Qwen3 layers are used
  • Run existing tests

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (3)
  • WIP
  • DO NOT MERGE
  • DRAFT

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c15f599b-e08f-411e-9e76-7681c032e696

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch qwen3-default-drafter-arch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Orestis Zambounis <orestis.zambounis@gmail.com>
@orestis-z
orestis-z force-pushed the qwen3-default-drafter-arch branch from 8621e97 to b75682e Compare June 18, 2026 14:56

@shanjiaz shanjiaz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's hold off landing this and wait for Ben's PR on vllm's side to land first?

@rahul-tuli rahul-tuli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll land once the blocking PR is in

@orestis-z

Copy link
Copy Markdown
Collaborator Author

Looks good! Let's hold off landing this and wait for Ben's PR on vllm's side to land first?

totally yes!

@benchislett

Copy link
Copy Markdown
Member

On the same note of arch improvement, I recommend adopting the EAGLE3.1 setup: use separate norms on each of the input features before projecting, and use the post-norm hidden state into subsequent draft/TTT steps.

Example checkpoint here: https://huggingface.co/lightseekorg/kimi-k2.6-eagle3.1-mla
Config flags are "fc_norm" and "norm_output".

It is supported in vLLM for both Llama and Qwen3-based EAGLE drafters

@orestis-z

orestis-z commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator Author

On the same note of arch improvement, I recommend adopting the EAGLE3.1 setup: use separate norms on each of the input features before projecting, and use the post-norm hidden state into subsequent draft/TTT steps.

Example checkpoint here: https://huggingface.co/lightseekorg/kimi-k2.6-eagle3.1-mla Config flags are "fc_norm" and "norm_output".

It is supported in vLLM for both Llama and Qwen3-based EAGLE drafters

Thanks for your suggestion @benchislett. Totally agree and I have this WIP to support 3.1 setup: #610. And thanks for the checkpoint.

@orestis-z

Copy link
Copy Markdown
Collaborator Author

@rahul-tuli @shanjiaz no more blockers, ready to land?

@shanjiaz shanjiaz added the ready This PR is ready for review label Jun 22, 2026
@shanjiaz
shanjiaz enabled auto-merge (squash) June 22, 2026 14:29
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

Link Check Results (REPO)

All links are now valid - this issue has been resolved.


Marked as resolved: 7b2f765

@shanjiaz
shanjiaz merged commit 03ba008 into main Jun 22, 2026
9 checks passed
@shanjiaz
shanjiaz deleted the qwen3-default-drafter-arch branch June 22, 2026 23:00
orestis-z added a commit to orestis-z/speculators that referenced this pull request Jun 29, 2026
PR vllm-project#620 changed the argparse default to qwen3 but missed the
function-level default in create_transformer_layer_config and left a
warning that now fires on every default training run.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Orestis Zambounis <orestis.zambounis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready This PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants