Skip to content

Conversation

@dejwCake
Copy link
Contributor

Due L12.34 added config to Queue class, there is a collision with name. So the name in this package has changed to RabbitMQConfig.
Docker compose now has the app and fixed ports.
Test are fixed by style.

@dejwCake dejwCake closed this Oct 19, 2025
@FrittenKeeZ
Copy link

Why was this closed? There's an obvious breaking change regarding config:

   Whoops\Exception\ErrorException 

  Type of VladimirYuldashev\LaravelQueueRabbitMQ\Queue\RabbitMQQueue::$config must not be defined (as in class Illuminate\Queue\Queue)

  at vendor/vladimir-yuldashev/laravel-queue-rabbitmq/src/Queue/RabbitMQQueue.php:30
     26use Throwable;
     27use VladimirYuldashev\LaravelQueueRabbitMQ\Contracts\RabbitMQQueueContract;
     28use VladimirYuldashev\LaravelQueueRabbitMQ\Queue\Jobs\RabbitMQJob;
     29▕ 
  ➜  30class RabbitMQQueue extends Queue implements QueueContract, RabbitMQQueueContract
     31▕ {
     32/**
     33▕      * The RabbitMQ connection instance.
     34▕      */
   Symfony\Component\ErrorHandler\Error\FatalError 

  Access level to VladimirYuldashev\LaravelQueueRabbitMQ\Queue\RabbitMQQueue::getConfig() must be public (as in class Illuminate\Queue\Queue)

  at vendor/vladimir-yuldashev/laravel-queue-rabbitmq/src/Queue/RabbitMQQueue.php:737
    733734return [$destination, $exchange, $exchangeType, $attempts];
    735▕     }
    736▕ 
  ➜ 737▕     protected function getConfig(): QueueConfig
    738▕     {
    739return $this->config;
    740▕     }
    741

@dejwCake
Copy link
Contributor Author

I did not wanted to merge it here, as there are also unrelated changes, feel free to take the code and use it, or I can prepare a different MR, when I will have a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants