Fix -Werror=enum-int-mismatch in lws_tls_server_abort_connection() - #2824
Closed
kraj wants to merge 1 commit into
Closed
Fix -Werror=enum-int-mismatch in lws_tls_server_abort_connection()#2824kraj wants to merge 1 commit into
kraj wants to merge 1 commit into
Conversation
GCC 13 is findinf this function signature mismatch. ../git/lib/tls/openssl/openssl-server.c:713:1: error: conflicting types for 'lws_tls_server_abort_connection' due to enum/integer mismatch; have 'int(struct lws *)' [-Werror=enum-int-mismatch] Signed-off-by: Khem Raj <raj.khem@gmail.com>
|
Just hit this issue. |
|
Is there any reason, this PR hasn't been accepted yet? |
|
Running into the same issue, please merge |
Contributor
|
+1 |
oskarirauta
added a commit
to oskarirauta/local-overrides
that referenced
this pull request
May 28, 2023
patch source for openssl is at warmcat/libwebsockets#2824 I patched it similarly for mbedtls as well Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com>
oskarirauta
added a commit
to oskarirauta/packages
that referenced
this pull request
May 28, 2023
…connection() with gcc 13 libwebsockets fails with -Werror=enum-int-mismatch with both SSL variants. These 2 patches work out that issue. Problem is mentioned as a issue in openwrt#20949 and instead of overriding issue with appropriate CFLAGS, this approach was suggested for me as it's been made as a PR (for openssl) at warmcat/libwebsockets#2824 Second patch for mbedtls, was made by me using same approach as was used of openssl. Eventually these propably will be merged into libwebsockets mainstream. Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com>
|
Patch is incomplete, it addresses only openssl- fix should be made available for both openssl and mbedtls. Such patch is introduced in PR openwrt/packages#20949 I would recommend merging a fix for mbedtls as well in this commit. |
neheb
pushed a commit
to openwrt/packages
that referenced
this pull request
Jul 1, 2023
…connection() with gcc 13 libwebsockets fails with -Werror=enum-int-mismatch with both SSL variants. These 2 patches work out that issue. Problem is mentioned as a issue in #20949 and instead of overriding issue with appropriate CFLAGS, this approach was suggested for me as it's been made as a PR (for openssl) at warmcat/libwebsockets#2824 Second patch for mbedtls, was made by me using same approach as was used of openssl. Eventually these propably will be merged into libwebsockets mainstream. Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com>
lu-zero
pushed a commit
to domo-iot/packages
that referenced
this pull request
Oct 23, 2023
…connection() with gcc 13 libwebsockets fails with -Werror=enum-int-mismatch with both SSL variants. These 2 patches work out that issue. Problem is mentioned as a issue in openwrt#20949 and instead of overriding issue with appropriate CFLAGS, this approach was suggested for me as it's been made as a PR (for openssl) at warmcat/libwebsockets#2824 Second patch for mbedtls, was made by me using same approach as was used of openssl. Eventually these propably will be merged into libwebsockets mainstream. Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com>
lws-team
force-pushed
the
main
branch
2 times, most recently
from
November 13, 2023 09:35
07b1c27 to
a99b954
Compare
Member
|
The openssl patch seems to have been in both main / v4.3-stable for a while... I added Khem's change on both as well now. Thanks and sorry for the long delay. |
gjp1120
pushed a commit
to gjp1120/packages
that referenced
this pull request
Jan 18, 2024
…connection() with gcc 13 libwebsockets fails with -Werror=enum-int-mismatch with both SSL variants. These 2 patches work out that issue. Problem is mentioned as a issue in openwrt/packages#20949 and instead of overriding issue with appropriate CFLAGS, this approach was suggested for me as it's been made as a PR (for openssl) at warmcat/libwebsockets#2824 Second patch for mbedtls, was made by me using same approach as was used of openssl. Eventually these propably will be merged into libwebsockets mainstream. Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com>
aiamadeus
pushed a commit
to coolsnowwolf/packages
that referenced
this pull request
Jan 18, 2024
with gcc 13 libwebsockets fails with -Werror=enum-int-mismatch with both SSL variants. These 2 patches work out that issue. Problem is mentioned as a issue in openwrt/packages#20949 and instead of overriding issue with appropriate CFLAGS, this approach was suggested for me as it's been made as a PR (for openssl) at warmcat/libwebsockets#2824 Second patch for mbedtls, was made by me using same approach as was used of openssl. Eventually these propably will be merged into libwebsockets mainstream. Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com> Co-authored-by: Oskari Rauta <oskari.rauta@gmail.com>
1715173329
pushed a commit
to immortalwrt/packages
that referenced
this pull request
Apr 29, 2024
…connection() with gcc 13 libwebsockets fails with -Werror=enum-int-mismatch with both SSL variants. These 2 patches work out that issue. Problem is mentioned as a issue in openwrt/packages#20949 and instead of overriding issue with appropriate CFLAGS, this approach was suggested for me as it's been made as a PR (for openssl) at warmcat/libwebsockets#2824 Second patch for mbedtls, was made by me using same approach as was used of openssl. Eventually these propably will be merged into libwebsockets mainstream. Signed-off-by: Oskari Rauta <oskari.rauta@gmail.com> (cherry picked from commit 6a897e2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 13 is findinf this function signature mismatch.
../git/lib/tls/openssl/openssl-server.c:713:1: error: conflicting types for 'lws_tls_server_abort_connection' due to enum/integer mismatch; have 'int(struct lws *)' [-Werror=enum-int-mismatch]
Signed-off-by: Khem Raj raj.khem@gmail.com