Change ckeditor5 language config propety check to handle null prototype #1107
+4
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-lejman
requested review from
carla-at-wiris,
jgonzalez-at-wiris,
usantos-at-wiris,
xjiang-at-wiris and
ncornaglia-at-wiris
as code owners
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I am a developer of CKEditor 5.
CKEditor5 uses a null-prototype object when the editor configuration is modified using the editor.config.define() function, in order to prevent prototype pollution vulnerabilities.
https://github.com/ckeditor/ckeditor5/blob/master/packages/ckeditor5-utils/src/config.ts#L198
MathType integration uses hasOwnProperty on the language object from the config, which causes an error when that property is defined using editor.config.define(), as the resulting object has a null prototype and does not include the hasOwnProperty method.
We need this change to prevent editor crashes when the language configuration is modified in this way.
Closes: #1106