Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Already added roles not visible in GW environment issue #860

Merged
merged 4 commits into from
Feb 7, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
handled added roles deletion
  • Loading branch information
ShakyaPr committed Jan 30, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 2db0d0d32b6f431e1a957095159e0b8643d2de6a
Original file line number Diff line number Diff line change
@@ -141,10 +141,10 @@ function AddEditGWEnvironment(props) {
const [invalidRoles, setInvalidRoles] = useState([]);
const [roleValidity, setRoleValidity] = useState(true);
const { gatewayTypes } = settings;
const initialPermissions = dataRow && dataRow.permissions
? dataRow.permissions
: { roles: [], permissionType: 'PUBLIC' };
const [initialState, setInitialState] = useState(() => {
const initialPermissions = dataRow && dataRow.permissions
? dataRow.permissions
: { roles: [], permissionType: 'PUBLIC' };
return {
displayName: '',
description: '',
@@ -180,6 +180,8 @@ function AddEditGWEnvironment(props) {
if (invalidRolesArray.length === 0) {
setRoleValidity(true);
}
} else if (roles.includes(role)) {
setRoles(roles.filter((existingRole) => existingRole !== role));
} else {
setValidRoles(validRoles.filter((existingRole) => existingRole !== role));
}
Loading